Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuring a trigger - 0 for GPS data throws error #317

Closed
pavinod opened this issue Aug 21, 2023 · 2 comments
Closed

Configuring a trigger - 0 for GPS data throws error #317

pavinod opened this issue Aug 21, 2023 · 2 comments
Assignees
@janoliver20
Labels
bug Something isn't working

Comments

@pavinod
Copy link
Member

pavinod commented Aug 21, 2023

specifying "0" as the value for GPS data throws an error, but no explanation or help around why and what to change
Suggestion: add an error message or tooltip to help the user understand the error and fix it

(Faith)
benitsch added a commit that referenced this issue Jul 17, 2024
@benitsch
#317: Change date to date-time
3ceecad 
* Add Seconds (59) to "to" date as well
benitsch added a commit that referenced this issue Jul 18, 2024
@benitsch
#317: Change date to date-time
f56bc4e 
* Add Seconds (59) to "to" date as well
@alireza-dhp alireza-dhp added the bug Something isn't working label Oct 21, 2024
janoliver20 added a commit that referenced this issue Dec 3, 2024
@janoliver20
#317: Improve validation logic and button formatting
a32b1eb 
Refactor validation to use a new `hasData` utility, ensuring non-empty strings are considered valid. Simplify button formatting for trigger group actions by removing unnecessary span closing tags. Added a utility function in `dataUtils.ts` to streamline data presence checks.
@janoliver20
Copy link

#563

janoliver20 added a commit that referenced this issue Dec 3, 2024
@janoliver20
Merge pull request #563 from MORE-Platform/317-configuring-a-trigger-…
6656909 
…--0-for-gps-data-throws-error

#317: Improve validation logic and button formatting
@andresgruber
Copy link
Contributor

andresgruber commented Dec 3, 2024 •
edited
Loading

0 is a valid input für a trigger, therefore the validation logic has been changed and the error does not appear anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janoliver20 janoliver20

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/317-configuring-a-trigger---0-for-gps-data-throws-error MORE-Platform/more-studymanager-frontend
4 participants
@andresgruber @pavinod @janoliver20 @alireza-dhp