-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landice interpolation unification #817
Merged
trhille
merged 13 commits into
MPAS-Dev:main
from
andrewdnolan:landice/interpolation_unification
Oct 2, 2024
Merged
Landice interpolation unification #817
trhille
merged 13 commits into
MPAS-Dev:main
from
andrewdnolan:landice/interpolation_unification
Oct 2, 2024
Commits on Sep 13, 2024
-
Unify
compass.landice.mesh.interp...
functions into a single func.Added a single function that should incorporate all the functionality of the exisiting `compass.landice.mesh.interp_ais_bedmachine()` and `compass.landice.mesh.interp_ais_measures()` functions, but that is general enough to work for both GIS and AIS, as well as for MEASURES and BedMachine datasets.
Configuration menu - View commit details
-
Copy full SHA for 79cfe7c - Browse repository at this point
Copy the full SHA 79cfe7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8aedc7f - Browse repository at this point
Copy the full SHA 8aedc7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3ce601 - Browse repository at this point
Copy the full SHA d3ce601View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9ab5b1 - Browse repository at this point
Copy the full SHA d9ab5b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0771a66 - Browse repository at this point
Copy the full SHA 0771a66View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a8c328 - Browse repository at this point
Copy the full SHA 2a8c328View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a0cee8 - Browse repository at this point
Copy the full SHA 6a0cee8View commit details -
Switch to list concatenation for variables specification.
Add the list of requested variables to the `args` list by concating. Previously I was manually creating the space seperated list (i.e string) when a list of variables was passed to the girdded inerpolator function. This space seperated string was not correctly parsed by the `mpas_tool.logging.check_call` function resulting in the variables not being inerpolated.
Configuration menu - View commit details
-
Copy full SHA for b281644 - Browse repository at this point
Copy the full SHA b281644View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdae362 - Browse repository at this point
Copy the full SHA bdae362View commit details -
Configuration menu - View commit details
-
Copy full SHA for 626f11a - Browse repository at this point
Copy the full SHA 626f11aView commit details
Commits on Oct 1, 2024
-
Add
sort_mesh
call tobuild_mali_mesh
framework function.Sorting the global indicies will improve memory performance of `cellsOnCell` and such. Additionally, sorting will help with PIO decompostion and ice-sheet-coupler communication.
Configuration menu - View commit details
-
Copy full SHA for 4338977 - Browse repository at this point
Copy the full SHA 4338977View commit details -
Apply suggestions from code review
Co-authored-by: Trevor Hillebrand <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ed7b85e - Browse repository at this point
Copy the full SHA ed7b85eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 490e606 - Browse repository at this point
Copy the full SHA 490e606View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.