Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landice interpolation unification #817

Merged
merged 13 commits into from
Oct 2, 2024

Commits on Sep 13, 2024

  1. Unify compass.landice.mesh.interp... functions into a single func.

    Added a single function that should incorporate all the functionality
    of the exisiting `compass.landice.mesh.interp_ais_bedmachine()` and
    `compass.landice.mesh.interp_ais_measures()` functions, but that is
    general enough to work for both GIS and AIS, as well as for MEASURES
    and BedMachine datasets.
    andrewdnolan committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    79cfe7c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8aedc7f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d3ce601 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d9ab5b1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0771a66 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2a8c328 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6a0cee8 View commit details
    Browse the repository at this point in the history
  8. Switch to list concatenation for variables specification.

    Add the list of requested variables to the `args` list by concating.
    Previously I was manually creating the space seperated list (i.e string)
    when a list of variables was passed to the girdded inerpolator function.
    This space seperated string was not correctly parsed by the
    `mpas_tool.logging.check_call` function resulting in the variables not
    being inerpolated.
    andrewdnolan committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b281644 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    bdae362 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    626f11a View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Add sort_mesh call to build_mali_mesh framework function.

    Sorting the global indicies will improve memory performance of
    `cellsOnCell` and such. Additionally, sorting will help with
    PIO decompostion and ice-sheet-coupler communication.
    andrewdnolan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4338977 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Trevor Hillebrand <[email protected]>
    andrewdnolan and trhille authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    ed7b85e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    490e606 View commit details
    Browse the repository at this point in the history