Mask only topography above sea level when remapping BedMachine topo #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For better consistency when we move to MALI coupling, we want the topography to be interpolated without masking out grounded ice.
Add a `bathymetry_mask` field to indicate where this has happened
TestingThis has been successfully tested along with #807 in: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge updates the utility that creates the merged BedMachine and GEBCO topography dataset to include bathymetry and ice topography under grounded ice as long as that ice below sea level. This is done to make the topography used in simulations without MALI coupling more similar to simulations where the topography will come from MALI in the near future. Since grounding lines will move, we do not wish to mask the topography to only the floating domain.
However, including topography above sea level is problematic. It can result in both bathymetry and ice-draft values that are above sea level even in cells where a significant fraction of the cell is below sea level (e.g. when bathymetry is shallow in the portion of the cell that is below sea level but steep in the portion that is above sea level).
Similarly, we will want to have MALI pass only the portion of the topography that is below sea level, along with a fraction of each cell that is below sea level.
Checklist
Testingin this PR) any testing that was used to verify the changes