Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxes inside a sample group #67

Open
podborski opened this issue Sep 5, 2023 · 3 comments
Open

Boxes inside a sample group #67

podborski opened this issue Sep 5, 2023 · 3 comments
Labels
inconsistent data Inconsistency between specification data and the data in this repository

Comments

@podborski
Copy link
Member

podborski commented Sep 5, 2023

Summary

Not so sure how to deal with this one in the framework but SVCDependencyRangeBox - svop is a box which is used inside a scif sample group. so the container can not be sgpd and so far we didn't cover the case where boxes are added inside a sample group.

@podborski podborski added the inconsistent data Inconsistency between specification data and the data in this repository label Sep 5, 2023
@DenizUgur
Copy link
Collaborator

Not sure if I understood correctly but I see couple of examples whose container is scif here. Can you elaborate on what is missing with the framework?

podborski added a commit that referenced this issue Sep 6, 2023
@podborski
Copy link
Member Author

I didn't test it yet. but will it be possible to search for svdr (was called svop by mistake) for example? or will it be ignored because it is buried inside a sample group?

@DenizUgur
Copy link
Collaborator

It will be possible to search for it because we are also looking for the grouping_type in sgpd.

if "@grouping_type" in value:
sg_entry = {"@Type": value["@grouping_type"]}
add_variant(add, sg_entry, path + [fourcc])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inconsistent data Inconsistency between specification data and the data in this repository
Projects
None yet
Development

No branches or pull requests

2 participants