Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify/Extend MP4PrivateMovieRecord #40

Open
lkondrad opened this issue Jan 19, 2023 · 0 comments
Open

Modify/Extend MP4PrivateMovieRecord #40

lkondrad opened this issue Jan 19, 2023 · 0 comments

Comments

@lkondrad
Copy link

MP4PrivateMovieRecord structure in MP4Atoms.h contains pointers to file level boxes :

  • MP4AtomPtr moovAtomPtr; /* might be a moof or a moov */
  • MP4AtomPtr ftyp; /* the file type atom */
  • MP4AtomPtr jp2h; /* for JPEG-2000, the JP2 header atom */
  • MP4AtomPtr sgnt; /* for JPEG-2000, the signature atom */
  • MP4AtomPtr meta; /* file-level meta-data */
  • MP4AtomPtr meco; /* Deprecated file-level additional meta-data container */

Part 12 defines other boxes that can be on File level (e.g. ExtendedTypeBox) but it is not possible to include them in the file using current implementation of the library.

The future prove way would be to modify the structure to store MP4AtomPtr to the boxes in MP4LinkedList? The order in the list would be the order in which the boxes are stored. Functions to get a box of given type form the record could be added. Unfortunately, that change would affect the library in many places.

The quick fix would be to add new pointers and modify LocalPutMovieIntoHandle function from MP4MovieFile.c to handle them when storing the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant