Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COM_LoadFile not enough space for maps #200

Open
SaintWish opened this issue Apr 7, 2023 · 5 comments
Open

COM_LoadFile not enough space for maps #200

SaintWish opened this issue Apr 7, 2023 · 5 comments
Labels
bug 🐛 Something isn't working critical ⚠️ Stuff that needs to be addressed as soon as possible. help wanted Extra attention is needed

Comments

@SaintWish
Copy link
Contributor

SaintWish commented Apr 7, 2023

This exception seems to happen after a server changes levels a few time, seems to mostly affect unstable branch. It might be due to a memory not being cleared for some reason somewhere, but hard to know where since that's all that error gives.

It seems to have happened somewhere around this commit 7bfdd90 which doesn't make sense, since that only affected the client...

@SaintWish SaintWish added bug 🐛 Something isn't working help wanted Extra attention is needed critical ⚠️ Stuff that needs to be addressed as soon as possible. labels Apr 7, 2023
@thesupersoup
Copy link

I see a few concerning things about string handling at a glance, but I don't see where the vector is properly cleared (calling .clear() is insufficient, line 249 in MSCLGlobals::RemoveAllEntities())

We may want to consider changing the m_Strings.clear() call to std::vector<std::string>().swap(m_Strings) for proper reallocation

@SaintWish
Copy link
Contributor Author

That's a good idea, I was also planning on replacing the code custom mslist and msstring with standard variant to also help with the memory issue.

@SaintWish
Copy link
Contributor Author

This is the issue for what I was talking about above #179 also started doing it in a separate branch just ran out of time to finish it.

@thesupersoup
Copy link

I'm very much for using standard types and structures, but I also know that it sometimes isn't so easy even when it should be. I'll be prepared to help with that transition once it's time.

@SaintWish
Copy link
Contributor Author

This issue kind of relates to the memory issue as well #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working critical ⚠️ Stuff that needs to be addressed as soon as possible. help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants