Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retravaille les noms des routes et controllers #1048

Closed
wants to merge 1 commit into from

Conversation

florimondmanca
Copy link
Collaborator

Cette PR repasse sur l'ensemble des controllers pour s'assurer de la cohérence entre :

  • Nom de la route
  • Nom du controller
  • Nom de la classe de test du controller
  • Nom du template

Ainsi que de la cohérence d'ensemble (par ex pour les fragments)

@florimondmanca
Copy link
Collaborator Author

La CI est KO tant que la BDTOPO est en train d'être réimportée (pas encore fini)

@florimondmanca florimondmanca force-pushed the refactor/route-names branch 2 times, most recently from b2eb563 to 4611979 Compare November 4, 2024 13:39
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.83%. Comparing base (81d6108) to head (a8f6720).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1048   +/-   ##
=========================================
  Coverage     98.83%   98.83%           
  Complexity     1712     1712           
=========================================
  Files           338      338           
  Lines          7399     7399           
=========================================
  Hits           7313     7313           
  Misses           86       86           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@florimondmanca florimondmanca marked this pull request as ready for review November 4, 2024 13:59
@florimondmanca
Copy link
Collaborator Author

Je vais clore car il aurait fallu procéder par plus petits morceaux, là c'est un peu "risqué".

Je ferai des PR quand l'occasion se présente pour renommer tel ou tel controller

@florimondmanca florimondmanca deleted the refactor/route-names branch November 18, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faire une passe sur le naming global des routes Symfony
2 participants