diff --git a/src/GameLogic/PlayerActions/PlayerStore/BuyRequestAction.cs b/src/GameLogic/PlayerActions/PlayerStore/BuyRequestAction.cs index 938be5e0c..fbb3e28f8 100644 --- a/src/GameLogic/PlayerActions/PlayerStore/BuyRequestAction.cs +++ b/src/GameLogic/PlayerActions/PlayerStore/BuyRequestAction.cs @@ -70,7 +70,6 @@ public async ValueTask BuyItemAsync(Player player, Player requestedPlayer, byte if (!requestedPlayer.ShopStorage.StoreOpen) { player.Logger.LogDebug("Store not open anymore, Character {0}", requestedPlayer.SelectedCharacter?.Name); - //await player.InvokeViewPlugInAsync(p => p.ShowMessageAsync("Player's Store not open anymore.", MessageType.BlueNormal)).ConfigureAwait(false); await player.InvokeViewPlugInAsync(p => p.ShowResultAsync(requestedPlayer, ItemBuyResult.ShopNotOpened, null)).ConfigureAwait(false); return; } @@ -79,7 +78,6 @@ public async ValueTask BuyItemAsync(Player player, Player requestedPlayer, byte if (item is null) { await player.InvokeViewPlugInAsync(p => p.ShowResultAsync(requestedPlayer, ItemBuyResult.InvalidShopSlot, null)).ConfigureAwait(false); - // await player.InvokeViewPlugInAsync(p => p.ShowMessageAsync("Sorry, Item was sold in the meantime.", MessageType.BlueNormal)).ConfigureAwait(false); return; } diff --git a/src/GameServer/RemoteView/Character/AddExperienceExtendedPlugIn.cs b/src/GameServer/RemoteView/Character/AddExperienceExtendedPlugIn.cs index d13ea371f..553773a1b 100644 --- a/src/GameServer/RemoteView/Character/AddExperienceExtendedPlugIn.cs +++ b/src/GameServer/RemoteView/Character/AddExperienceExtendedPlugIn.cs @@ -48,7 +48,7 @@ public async ValueTask AddExperienceAsync(int exp, IAttackable? obj, ExperienceT await this._player.Connection.SendExperienceGainedExtendedAsync( Convert(experienceType), (uint)exp, - (uint)damage, + damage, killedId, killerId) .ConfigureAwait(false); diff --git a/src/GameServer/RemoteView/PlayerShop/ShowShopItemListExtendedPlugIn.cs b/src/GameServer/RemoteView/PlayerShop/ShowShopItemListExtendedPlugIn.cs index 269e2b306..5389c65a2 100644 --- a/src/GameServer/RemoteView/PlayerShop/ShowShopItemListExtendedPlugIn.cs +++ b/src/GameServer/RemoteView/PlayerShop/ShowShopItemListExtendedPlugIn.cs @@ -44,7 +44,7 @@ int Write() { var size = PlayerShopItemListExtendedRef.GetRequiredSize(items.Count, PlayerShopItemExtendedRef.GetRequiredSize(itemSerializer.NeededSpace)); var span = connection.Output.GetSpan(size)[..size]; - var packet = new PlayerShopItemListExtendedRef(span) + _ = new PlayerShopItemListExtendedRef(span) { Action = isUpdate ? PlayerShopItemListExtended.ActionKind.UpdateAfterItemChange diff --git a/src/GameServer/RemoteView/Quest/QuestProgressExtendedPlugIn.cs b/src/GameServer/RemoteView/Quest/QuestProgressExtendedPlugIn.cs index 6ec04b15a..e8c3c1192 100644 --- a/src/GameServer/RemoteView/Quest/QuestProgressExtendedPlugIn.cs +++ b/src/GameServer/RemoteView/Quest/QuestProgressExtendedPlugIn.cs @@ -44,7 +44,7 @@ int Write() { var size = QuestProgressExtendedRef.Length; var span = connection.Output.GetSpan(size)[..size]; - var packet = new QuestProgressExtendedRef(span) + _ = new QuestProgressExtendedRef(span) { QuestGroup = (ushort)quest.Group, }; diff --git a/src/GameServer/RemoteView/Quest/QuestStateResponsePlugIn.cs b/src/GameServer/RemoteView/Quest/QuestStateResponsePlugIn.cs index 169b86eda..bc8ba5c47 100644 --- a/src/GameServer/RemoteView/Quest/QuestStateResponsePlugIn.cs +++ b/src/GameServer/RemoteView/Quest/QuestStateResponsePlugIn.cs @@ -34,7 +34,7 @@ public async ValueTask ShowQuestStateAsync(CharacterQuestState? questState) { if (questState is null || questState.Group == QuestConstants.LegacyQuestGroup) { - await this.ShowLegacyQuestStateAsync(questState ??= this._player.SelectedCharacter?.QuestStates.FirstOrDefault(state => state.Group == QuestConstants.LegacyQuestGroup)).ConfigureAwait(false); + await this.ShowLegacyQuestStateAsync(this._player.SelectedCharacter?.QuestStates.FirstOrDefault(state => state.Group == QuestConstants.LegacyQuestGroup)).ConfigureAwait(false); return; } diff --git a/src/GameServer/RemoteView/World/AppearanceChangedPlugIn.cs b/src/GameServer/RemoteView/World/AppearanceChangedPlugIn.cs index 57d47670b..56213edb7 100644 --- a/src/GameServer/RemoteView/World/AppearanceChangedPlugIn.cs +++ b/src/GameServer/RemoteView/World/AppearanceChangedPlugIn.cs @@ -97,7 +97,7 @@ public class AppearanceChangedExtendedPlugIn : IAppearanceChangedPlugIn public async ValueTask AppearanceChangedAsync(Player changedPlayer, Item item) { var connection = this._player.Connection; - if (connection is null || changedPlayer.Inventory is not { } inventory) + if (connection is null || changedPlayer.Inventory is null) { return; }