Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatfs/drivers/fatfs_sd.c cannot be compiled with GCC 7.3.1 #32

Open
alpo opened this issue Apr 19, 2019 · 1 comment
Open

fatfs/drivers/fatfs_sd.c cannot be compiled with GCC 7.3.1 #32

alpo opened this issue Apr 19, 2019 · 1 comment

Comments

@alpo
Copy link
Contributor

alpo commented Apr 19, 2019

Using gcc version 7.3.1 20180622 (release) [ARM/embedded-7-branch revision 261907] (GNU Tools for Arm Embedded Processors 7-2018-q3-update)
I'm getting the error
`fatfs/drivers/fatfs_sd.c:158:12: error: conflicting types for 'select'

/usr/arm-none-eabi/include/sys/select.h:62:5: note: previous declaration of 'select' was here
int select __P ((int __n, fd_set *__readfds, fd_set *__writefds,`
Shouldn't the use of system function names be considered as bad practice and exterminated?

@MaJerle
Copy link
Owner

MaJerle commented Apr 19, 2019

@alpo yes, could be. Could you do please a pull request with valid change?

MaJerle added a commit that referenced this issue Apr 19, 2019
fix name conflict with sys/select.h  (fixes issue #32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants