Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase QR code algorithm breaks export to Google Authenticator / clearer labels #65

Open
sitsofe opened this issue Oct 14, 2024 · 4 comments
Labels

Comments

@sitsofe
Copy link

sitsofe commented Oct 14, 2024

Google Authenticator on Android rejects QR codes generated by MacPass because the algorithm isn't in capitals. The algorithm text appears to come from stringForAlgorithm in KPKOTPGenerator.m
.

Additionally it would be great if the title was included in label generated for TOTP URL so that it is easier to differentiate imported keys that share the same username...

@mstarke
Copy link
Member

mstarke commented Nov 11, 2024

Nice find. This this happen recently or was this an issue all the time? I did use the style from KeePassXC so I never looked anywhere else to verify if the codes worked properly. Including the title should be no problem.

@sitsofe
Copy link
Author

sitsofe commented Nov 11, 2024

I think it's been an issue for all time.

For anyone who may come across this in the future, an old (archived) version of the Key Uri Format specification used by Google Authenticator is on https://github.com/google/google-authenticator/wiki/Key-Uri-Format#algorithm .

@mstarke
Copy link
Member

mstarke commented Nov 12, 2024

Thanks. I now remember that I did use the google spec as reference but never bothered about lower or upper case since this should not be an issue. Well. Seems like it is. This needs to be fixed then I suppose.

@mstarke mstarke added the bug label Nov 12, 2024
@sitsofe
Copy link
Author

sitsofe commented Nov 12, 2024

[...] since this should not be an issue

Of course you're right - it shouldn't have matter and other authenticators like Microsoft Authenticator don't mind about case so behaviour is not uniform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants