Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for custom text on banner #11

Open
sjennison opened this issue Aug 25, 2016 · 5 comments
Open

Allow for custom text on banner #11

sjennison opened this issue Aug 25, 2016 · 5 comments
Labels
beginner feature request

Comments

@sjennison
Copy link

It would be nice to allow for custom text on the banner
@Maddoc42
Copy link
Owner

Agreed 👍

Any thoughts on what should happen when the text becomes longer than the banner / icon? Resize the text? Or simply ignore since nobody will be able to read it anyways 😄

@sjennison
Copy link
Author

Yeah, I feel like ignoring it would be best (maybe set a max size on the input?).

@Maddoc42
Copy link
Owner

Maxe size on the input is neat, nice!

Anyone coming across this, PRs are welcome :)

@iskandergaba
Copy link

Whether you are going to implement it using max size or not, I feel like adding a "FREE" and "PRO" default presets makes sense

@Maddoc42
Copy link
Owner

Fair enough 👍 "free" and "pro" are up and running 😄

icon-free-re icon-pro-re

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Maddoc42 @sjennison @iskandergaba