You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's detected that defined threshold for min-coverage-changed-files property does not work properly in connection with setting 'fail-emoji'. Emoji for changed files always appear with positive sign even if threshold is not achieved.
But on PR comment I get emoji from setting 'pass-emoji' for changed file with coverage of 50.19% that's under thresholded 90%. Current picture from PR is depicted on the screenshot below:
Here emoji from setting 'fail-emoji' should have been set. But actually, pass-emoji is assigned that's wrong.
I verified, that on version 1.4 (later versions from 1.5 started working incorrectly for this function) it worked correctly. Let me put screenshot here (Just one thing, emoji settings did not exist on that version and appeared only from v1.5.):
Hint: may be this issue relates to already registered one #71
The text was updated successfully, but these errors were encountered:
It's detected that defined threshold for min-coverage-changed-files property does not work properly in connection with setting 'fail-emoji'. Emoji for changed files always appear with positive sign even if threshold is not achieved.
Let me put my example of the step configuration:
But on PR comment I get emoji from setting 'pass-emoji' for changed file with coverage of 50.19% that's under thresholded 90%. Current picture from PR is depicted on the screenshot below:
![image](https://private-user-images.githubusercontent.com/10928283/319455804-5e0106f4-779e-443f-913b-ce4df67a0bce.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxMjQ2ODQsIm5iZiI6MTcyNjEyNDM4NCwicGF0aCI6Ii8xMDkyODI4My8zMTk0NTU4MDQtNWUwMTA2ZjQtNzc5ZS00NDNmLTkxM2ItY2U0ZGY2N2EwYmNlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDA2NTk0NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFiNTE2N2NkMzA4YTIxYWNkNzAyYjc5OWJhMWMwYWZhNWRjZWMzYTNiNDg1Yjc1YmNlOTA1Zjc1YWFhN2M1ZmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.s3SJSYJ2qfWOo9KC7NyQOWRQ5W7sGem_FBJ49Q5sMJU)
Here emoji from setting 'fail-emoji' should have been set. But actually, pass-emoji is assigned that's wrong.
I verified, that on version 1.4 (later versions from 1.5 started working incorrectly for this function) it worked correctly. Let me put screenshot here (Just one thing, emoji settings did not exist on that version and appeared only from v1.5.):
![image](https://private-user-images.githubusercontent.com/10928283/319454352-fc2fe834-2525-4296-ae89-b364a101808c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxMjQ2ODQsIm5iZiI6MTcyNjEyNDM4NCwicGF0aCI6Ii8xMDkyODI4My8zMTk0NTQzNTItZmMyZmU4MzQtMjUyNS00Mjk2LWFlODktYjM2NGExMDE4MDhjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDA2NTk0NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM4M2Y5ZGY3ZjhlZDliYjdlM2Y1MDU0ZTYwOTdkYjEzYTNhMDQxMDVkMDY0NGEzMjdmZjg4ZDhhM2UzODE1NzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.uTpgrw0lo9NZxjkYDcZgffseTwvf04K4EzXFtEIuosI)
Hint: may be this issue relates to already registered one #71
The text was updated successfully, but these errors were encountered: