Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect emoji corresponding to code coverage on changed files in respect with set property min-coverage-changed-files #86

Open
AntonShypkov opened this issue Apr 4, 2024 · 0 comments
Assignees
Milestone

Comments

@AntonShypkov
Copy link

It's detected that defined threshold for min-coverage-changed-files property does not work properly in connection with setting 'fail-emoji'. Emoji for changed files always appear with positive sign even if threshold is not achieved.

Let me put my example of the step configuration:

  - name: Publish Unit Tests Coverage Results
    uses: madrapps/[email protected]
    id: unit-test-coverage
    with:
      paths: .....
      title: Unit Tests Code Coverage
      update-comment: true
      skip-if-no-changes: true
      debug-mode: true
      token: ....
      min-coverage-overall: 90
      min-coverage-changed-files: 90
      continue-on-error: false
      pass-emoji: ':green_circle:'
      fail-emoji: ':red_circle:'

But on PR comment I get emoji from setting 'pass-emoji' for changed file with coverage of 50.19% that's under thresholded 90%. Current picture from PR is depicted on the screenshot below:
image

Here emoji from setting 'fail-emoji' should have been set. But actually, pass-emoji is assigned that's wrong.

I verified, that on version 1.4 (later versions from 1.5 started working incorrectly for this function) it worked correctly. Let me put screenshot here (Just one thing, emoji settings did not exist on that version and appeared only from v1.5.):
image

Hint: may be this issue relates to already registered one #71

@instrap instrap self-assigned this Sep 8, 2024
@instrap instrap added this to the 1.7.2 milestone Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants