Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with New UI-Nervos DAO #160

Closed
silySuper opened this issue May 26, 2023 · 6 comments
Closed

Problems with New UI-Nervos DAO #160

silySuper opened this issue May 26, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@silySuper
Copy link

silySuper commented May 26, 2023

1.Same deposit amount,different operations have different continue results.Firstly, One can continue deposit,the other can not.Secondly,on same amout,one shows insufficient balance,the other does not shows.
截屏2023-05-26 14 52 02
截屏2023-05-26 14 53 03

The procedure is shown in the video:

2023-05-26.16.09.31.mov

2.UI document need chinese called "下一步",but this called “继续”, product manager may know this small change.

截屏2023-05-26 16 14 03
@silySuper silySuper assigned WhiteMinds and Danie0918 and unassigned WhiteMinds May 26, 2023
@FrederLu FrederLu added the bug Something isn't working label May 26, 2023
@Danie0918 Danie0918 assigned WhiteMinds and unassigned Danie0918 May 29, 2023
@WhiteMinds
Copy link

1.Same deposit amount,different operations have different continue results.

This behavior is consistent with the logic of the old UI (production version), but I am unsure if it is reasonable.
For example, there is no prompt for Slider because it will never exceed the balance, whereas the prompt appears for TextInput because it involves manually entering a number that exceeds the balance.

2.UI document need chinese called "下一步",but this called “继续”, product manager may know this small change.

Confirmation from @Danie0918 is required.

@Danie0918
Copy link
Contributor

1.Same deposit amount,different operations have different continue results.

This behavior is consistent with the logic of the old UI (production version), but I am unsure if it is reasonable. For example, there is no prompt for Slider because it will never exceed the balance, whereas the prompt appears for TextInput because it involves manually entering a number that exceeds the balance.

2.UI document need chinese called "下一步",but this called “继续”, product manager may know this small change.

Confirmation from @Danie0918 is required.

Regarding the copywriting, there will be no adjustments in this issue, and the UI is only used as a style reference.

@silySuper
Copy link
Author

OK

@WhiteMinds
Copy link

1.Same deposit amount,different operations have different continue results.Firstly, One can continue deposit,the other can not.Secondly,on same amout,one shows insufficient balance,the other does not shows.

This issue has been fixed in the latest branch (tested and confirmed): nervosnetwork/neuron#2688
Therefore, when the new-ui is merged into develop again, this problem will be automatically resolved. So, it can be ignored.

@yanguoyu
Copy link

yanguoyu commented Jun 8, 2023

@silySuper Develop has merged into new-ui branch, you can try it again with https://github.com/nervosnetwork/neuron/actions/runs/5194498526

@Danie0918 Danie0918 assigned silySuper and unassigned WhiteMinds Jun 12, 2023
@silySuper
Copy link
Author

verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

6 participants