Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting cell management #218

Closed
Keith-CY opened this issue Jul 8, 2023 · 20 comments
Closed

Supporting cell management #218

Keith-CY opened this issue Jul 8, 2023 · 20 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Keith-CY
Copy link
Member

Keith-CY commented Jul 8, 2023

This issue comes from #56 (comment)


【Cell Management】This page will display all live cells and allows users to manage them.

  1. The entry will be placed next to the balance under the overview page, where the balance still shows the full balance and needs to be prompted when there is a locked balance, click to view to enter the cell management page.
  2. The Cell Management page displays the number and list of live cells and allows for the management of these cells.
    • List Title:Display date, type, amount and status and support sorting.
    • Operation:Support view details, open in browser, lock/unlock and spend.
    • Batch operation:The user can select the cells to be manipulated by clicking on the entry or select all cells for batch manipulation.
  3. Locking or unlocking the cell requires verification of the wallet password.
  4. The spend cell will jump to the send page and bring in the full amount (including fees).

cell_management

@Keith-CY Keith-CY added the documentation Improvements or additions to documentation label Jul 8, 2023
@Keith-CY Keith-CY added this to Neuron Jul 8, 2023
@Keith-CY Keith-CY moved this to 📌Planning in Neuron Jul 8, 2023
@Keith-CY
Copy link
Member Author

Keith-CY commented Jul 8, 2023

Display date, type, amount and status and support sorting

Please add the definition of type, amount

@Keith-CY
Copy link
Member Author

Keith-CY commented Jul 8, 2023

A description field could be added to annotate a cell, similar to description of an address

@Keith-CY
Copy link
Member Author

Keith-CY commented Jul 8, 2023

Support view details leads to a window of transaction, which is a bit confusing and indirect.

What if show the detail of the cell, including outpoint, capacity, lock script, type script, data, and the transaction can be navigated by clicking outpoint

@yanguoyu
Copy link

yanguoyu commented Aug 22, 2023

Locking or unlocking the cell requires verification of the wallet password.

It's necessary to input the password when locking or unlocking because the result is only for the local wallet.

The spend cell will jump to the send page and bring in the full amount (including fees).

Can this action use other cells? @Danie0918

@yanguoyu
Copy link

yanguoyu commented Aug 22, 2023

  1. Add a table cell_local_info to save the cell description and lock status
  2. Add an API to get current wallet live cells from the output table
  3. Add an API to save or update cell_local_info
  4. Change the API generate tx to use the appointed live cell.
  5. Change the load-init-data and get-all-addresses API to return locked balance and unlocked balance.

@Danie0918
Copy link
Contributor

Locking or unlocking the cell requires verification of the wallet password.

It's necessary to input the password when locking or unlocking because the result is only for the local wallet.

The spend cell will jump to the send page and bring in the full amount (including fees).

Can this action use other cells? @Danie0918

This one operates on selected cells and does not contain additional cells.

@yanguoyu
Copy link

Locking or unlocking the cell requires verification of the wallet password.

It's necessary to input the password when locking or unlocking because the result is only for the local wallet.

What do you think about this? @Danie0918

@Danie0918
Copy link
Contributor

Locking or unlocking the cell requires verification of the wallet password.

It's necessary to input the password when locking or unlocking because the result is only for the local wallet.

What do you think about this? @Danie0918

That's how it's currently designed, what's the problem?

@yanguoyu
Copy link

Locking or unlocking the cell requires verification of the wallet password.

It's necessary to input the password when locking or unlocking because the result is only for the local wallet.

What do you think about this? @Danie0918

That's how it's currently designed, what's the problem?

My mistake, necessary -> unnecessary.

@Danie0918
Copy link
Contributor

For unlocking and locking we generally consider it to be a sensitive operation that will have an impact on the user's subsequent use of the balance, plus password verification to ensure that it is not a misuse. In addition, when it comes to the operation of user's assets, it is better to have a password verification to show the security of the software.

Besides, there are batch operations offered here, so even unlocking and unlocking multiple cells only requires one verification, which is not very burdensome for the user.

@yanguoyu
Copy link

For unlocking and locking we generally consider it to be a sensitive operation that will have an impact on the user's subsequent use of the balance, plus password verification to ensure that it is not a misuse. In addition, when it comes to the operation of user's assets, it is better to have a password verification to show the security of the software.

Besides, there are batch operations offered here, so even unlocking and unlocking multiple cells only requires one verification, which is not very burdensome for the user.

The action only affects local data, but not chain data. Maybe we can simply add a confirm dialog but not enter a password?

@Danie0918
Copy link
Contributor

For unlocking and locking we generally consider it to be a sensitive operation that will have an impact on the user's subsequent use of the balance, plus password verification to ensure that it is not a misuse. In addition, when it comes to the operation of user's assets, it is better to have a password verification to show the security of the software.
Besides, there are batch operations offered here, so even unlocking and unlocking multiple cells only requires one verification, which is not very burdensome for the user.

The action only affects local data, but not chain data. Maybe we can simply add a confirm dialog but not enter a password?

I understand what do you mean, but when it comes to operations involving user assets, I'd still recommend adding password verification. Although this is only for the local effect, but the user software has an impact on the use, it is best to need to verify that the operation is for my own.

@yanguoyu
Copy link

For unlocking and locking we generally consider it to be a sensitive operation that will have an impact on the user's subsequent use of the balance, plus password verification to ensure that it is not a misuse. In addition, when it comes to the operation of user's assets, it is better to have a password verification to show the security of the software.
Besides, there are batch operations offered here, so even unlocking and unlocking multiple cells only requires one verification, which is not very burdensome for the user.

The action only affects local data, but not chain data. Maybe we can simply add a confirm dialog but not enter a password?

I understand what do you mean, but when it comes to operations involving user assets, I'd still recommend adding password verification. Although this is only for the local effect, but the user software has an impact on the use, it is best to need to verify that the operation is for my own.

Once enter the password, users may think wheter this action will effect their assets. By the way, verify that the operation is for my own does not need password. We can check whether the lock script is owner the current wallet.

@Danie0918
Copy link
Contributor

Once enter the password, users may think wheter this action will effect their assets. By the way, verify that the operation is for my own does not need password. We can check whether the lock script is owner the current wallet.

'Once enter the password, users may think wheter this action will effect their assets. 'This is really a point to consider as well. But for passwords, can we use it as a kind of easy authentication for web2 user habits instead of treating it as a very serious security measure.

@yanguoyu
Copy link

Does the cell manage page need to show multisig / locktime or cheque cells? Because these cells can not spent before unlock or claim. So lock, unlock, and spent actions are useless for these cells. @Danie0918

@Danie0918
Copy link
Contributor

Does the cell manage page need to show multisig / locktime or cheque cells? Because these cells can not spent before unlock or claim. So lock, unlock, and spent actions are useless for these cells. @Danie0918

Cells need to be displayed, but selection and further actions such as lock, unlock, and spent actions are not supported.

@Danie0918
Copy link
Contributor

Does the cell manage page need to show multisig / locktime or cheque cells? Because these cells can not spent before unlock or claim. So lock, unlock, and spent actions are useless for these cells. @Danie0918

image

For this case, the cell can't be selected and spent, it only offers to view the details, so I plan to add an icon hint to make it easier for the user to understand the situation.

Can you help me add what I might meet? I need to provide the corresponding text to prompt the user. If there is already existing copy here, please provide it. @yanguoyu

@yanguoyu
Copy link

yanguoyu commented Sep 4, 2023

Can you help me add what I might meet?

  1. Cheque cells should be claimed before using it.
  2. We should wait for the end time to unlock the multisig / locktime cells.
  3. DAO cells should be withdrawn before using it.
  4. The spend cell will jump to the send page and bring in the full amount (including fees). Will this action only support sending ckb? If so, for sudt cells, they are better to send and receive at the asset account page. Otherwise, it will become complex with sending sudt and ckb at the same time.

If I think of other assets, I will append to here.

@Danie0918
Copy link
Contributor

The UI has been updated. @yanguoyu
URL:https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?type=design&node-id=22441-10468&mode=design

@Danie0918 Danie0918 moved this from 📌Planning to 🏗 In Progress in Neuron Sep 11, 2023
@Danie0918 Danie0918 assigned yanguoyu and unassigned Danie0918 Sep 11, 2023
@yanguoyu
Copy link

yanguoyu commented Oct 7, 2023

@Danie0918 Danie0918 moved this from 🏗 In Progress to 🔎 Code Review in Neuron Oct 7, 2023
@Danie0918 Danie0918 assigned Keith-CY, homura and WhiteMinds and unassigned yanguoyu Oct 16, 2023
@Danie0918 Danie0918 moved this from 🔎 Code Review to 👀 Testing in Neuron Oct 23, 2023
@Danie0918 Danie0918 moved this from 👀 Testing to 🚩Pre Release in Neuron Nov 27, 2023
@Danie0918 Danie0918 moved this from 🚩Pre Release to ✅ Done in Neuron Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

No branches or pull requests

5 participants