-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service for compatibility between Neuron and CKB node/client #254
Comments
Fw:
@Keith-CY Here is a slightly different message that I would suggest for use in the meantime since a compatibility table is not yet ready.
|
【Requirement content】Update CKB nodes with Neuron version check popup alerts. 1.When the running CKB node is newer than the Neuron internal ckb node version, and there exists a Neuron updater version. Text:The version of the CKB node does not match Neuron (v0.110.0), which may cause compatibility issues. Please update to the latest version of Neuron. 2.Add built-in compatibility table to alertAdd built-in compatibility table to alert When the running CKB node is incompatible with Neuron internal ckb node version. Text:CKB node is not compatible with Neuron (v0.110.0), please check before using it. (Learn more) |
This design includes 2 cases
IMO, the dialog in case 1 can also show the link to the compatibility table because it can be updated timely. When a new version of ckb node comes, the compatibility table can be updated and users will be led to the compatibility table for a check. If the link doesn't appear in the dialog of case 1, users using the latest ckb node cannot know if the latest ckb node works with neuron. But the link can be hidden until the compatibility table is ready |
When there is no new version with Neuron, should we also show the dialog? And maybe the latest Neuron's ckb version is smaller than the latest ckb version. @Danie0918 |
There is no need to display it in this case because there is no newer version to support it. |
When the users use the internal ckb node, there will be no dialog.
-> When the running CKB node is newer than the Neuron internal ckb node version, and there exists a Neuron updater version.
-> Add built-in compatibility table to alertAdd built-in compatibility table to alert When the running CKB node is incompatible with Neuron internal ckb node version. |
Is there a possibility that after updating |
It's possible,(like Neuron upgrades from v0.101.0 to v0.103.0 while the node is v0.112.0) but the case is rare(users always use the latest one) and the dialog keeps showing if the combination is not in our list.
The compatibility table should be arranged along with the the basic function so it is possible to check if neuron and ckb node are matched. But the page to show the compatibility table to users will be delivered later.
What do conditions 1 and 2 mean here? |
1.When the CKB node is newer than the Neuron version. |
Conditions 1 and 2 are satisfied at the same time and should be presented as condition 1. |
As mentioned at #254 (comment)
The dialog shows when Neuron cannot recognize the ckb node and lead users to check the compatibility table page. |
I may try this to complete it.
|
Sorry for checking the copy so late. I found |
Does the Chinese description need to change? Currently is |
How about |
If incompatibility is confirmed, should the user be advised to stop using the node? |
It's hard to confirm how the incompatibility will impact the functionality. So it's hard to advice users to stop using the external node. For instance, the external node doesn't |
This issue comes from nervosnetwork/neuron#2780
It's expected to have the following 2 functions
The text was updated successfully, but these errors were encountered: