Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neuron does not show Looking for assumed valid target tip #398

Open
yanguoyu opened this issue Jun 8, 2024 · 5 comments · Fixed by nervosnetwork/neuron#3195
Open

Neuron does not show Looking for assumed valid target tip #398

yanguoyu opened this issue Jun 8, 2024 · 5 comments · Fixed by nervosnetwork/neuron#3195
Assignees
Labels
bug Something isn't working

Comments

@yanguoyu
Copy link

yanguoyu commented Jun 8, 2024

The ckb's find the assumed valid target log has changed. So Neuron can not match it.
Before 0.112 https://github.com/nervosnetwork/ckb/blob/v0.112.1/sync/src/synchronizer/mod.rs#L132-L136

best known header number: {}, hash: {:#?}, \
                                 can't find assume valid target temporarily, hash: {:#?} \
                                 please wait

0.113~0.115 https://github.com/nervosnetwork/ckb/blob/v0.114.0/sync/src/synchronizer/mod.rs#L126-L129

best known header number: {}, hash: {:#?}, \
                                 temporarily can't find assume valid target, hash: {:#?} \
                                 Please wait

And 0.115 https://github.com/nervosnetwork/ckb/blob/v0.117.0-rc1/sync/src/synchronizer/mod.rs#L129-L132

"best known header {}-{}, \
                                 CKB is syncing to latest Header to find the assume valid target: {}. \
                                 Please wait. {}",

The log may change for other unknown reasons in the future, and we can not monitor the log's change.
So we'd better research another way to match that ckb is looking for assumed valid target.

@Danie0918 Danie0918 added the bug Something isn't working label Jun 11, 2024
@Danie0918 Danie0918 added this to Neuron Jun 11, 2024
@Danie0918 Danie0918 moved this to 📫Hold On in Neuron Jun 11, 2024
@Danie0918 Danie0918 moved this from 📫Hold On to 🆕 New in Neuron Jun 11, 2024
@Danie0918 Danie0918 moved this from 🆕 New to 🏗 In Progress in Neuron Jun 17, 2024
@Danie0918 Danie0918 removed their assignment Jun 17, 2024
@Danie0918
Copy link
Contributor

  1. Fixing neuron issues with hotfix.
  2. Create issue feedback in the ckbcore project.

@yanguoyu
Copy link
Author

nervosnetwork/ckb#4485

@yanguoyu
Copy link
Author

@yanguoyu yanguoyu moved this from 🏗 In Progress to 🔎 Code Review in Neuron Jun 21, 2024
@Danie0918 Danie0918 moved this from 🔎 Code Review to 👀 Testing in Neuron Jun 24, 2024
@Keith-CY Keith-CY moved this from 👀 Testing to 🚩Pre Release in Neuron Jun 24, 2024
@Danie0918 Danie0918 moved this from 🚩Pre Release to ✅ Done in Neuron Aug 1, 2024
@yanguoyu
Copy link
Author

yanguoyu commented Aug 8, 2024

nervosnetwork/ckb#4486 has merged, we can reopen this issue by using RPC to check the status. @Danie0918

@yanguoyu
Copy link
Author

I guess it's better to use RPC result after ckb-js/lumos#733 lumos adapt 0.117 RPC method.

@Danie0918 Danie0918 reopened this Aug 15, 2024
@Danie0918 Danie0918 moved this from ✅ Done to 🏗 In Progress in Neuron Aug 15, 2024
@Danie0918 Danie0918 moved this from 🏗 In Progress to 🎨 Designing in Neuron Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🎨 Designing
Development

Successfully merging a pull request may close this issue.

2 participants