From 119195caa5a21ea685334ae9880c9742c421aafb Mon Sep 17 00:00:00 2001 From: nereboss Date: Fri, 17 Nov 2023 13:44:20 +0100 Subject: [PATCH 1/2] Update PR template #3412 --- .github/pull_request_template.md | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 33c625fe0e..2b78a873e8 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,7 +2,7 @@ _**Please read the [CONTRIBUTING.md](https://github.com/MaibornWolff/codecharta/blob/main/CONTRIBUTING.md) before opening a PR.**_ -Issue: # +{Issue/Closes}: # ## Description @@ -10,4 +10,14 @@ Issue: # - What problem/issue are you fixing? - What does this PR implement and how? +## Definition of Done + +A PR is only ready for review once all the following acceptance criteria are fulfilled: +-[ ] Changes have been manually tested +-[ ] All TODOs related to this PR have been closed +-[ ] There are automated tests for newly written code and bug fixes +-[ ] All bugs discovered while working on this PR have been submitted as issues (if not already an open issue) +-[ ] Documentation (GH-pages, analysis/visualisation READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes) +-[ ] CHANGELOG.md has been updated + ## Screenshots or gifs From 3ad635fcf10117c556b91a1ef870b6248aca8eaf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niklas=20Knei=C3=9Fl?= <105795397+Nereboss@users.noreply.github.com> Date: Mon, 20 Nov 2023 09:15:16 +0100 Subject: [PATCH 2/2] Update .github/pull_request_template.md Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com> --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 2b78a873e8..e982c06d8a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -12,7 +12,7 @@ _**Please read the [CONTRIBUTING.md](https://github.com/MaibornWolff/codecharta/ ## Definition of Done -A PR is only ready for review once all the following acceptance criteria are fulfilled: +A PR is only ready for merge once all the following acceptance criteria are fulfilled: -[ ] Changes have been manually tested -[ ] All TODOs related to this PR have been closed -[ ] There are automated tests for newly written code and bug fixes