Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server improperly interpreting escaped start flag #21

Open
Rowbotronics opened this issue Jul 14, 2016 · 0 comments
Open

Server improperly interpreting escaped start flag #21

Rowbotronics opened this issue Jul 14, 2016 · 0 comments
Assignees

Comments

@Rowbotronics
Copy link
Collaborator

When an escaped start flag is present in a packet, the server correctly identifies the packet, but then also tries to interpret the section starting at the escaped flag as a second packet.

This is unlikely to cause any real issues as the falsely identified packet should always be discarded, but it raises false flags in the logs.

Jul 14 13:08:19 mcp node[27179]: Writing packet : fa1400010102000afefa52fb
Jul 14 13:08:19 mcp node[27179]: RAW Serial : fa,14,0,1,1,2,0,a
Jul 14 13:08:19 mcp node[27179]: RAW Serial : fa,14,0,1,1,2,0,a
Jul 14 13:08:19 mcp node[27179]: RAW Serial : fe,fa,52,fb
Jul 14 13:08:19 mcp node[27179]: Incoming packet: fa1400010102000afefa52fb
Jul 14 13:08:19 mcp node[27179]: RAW Serial : fe,fa,52,fb
Jul 14 13:08:19 mcp node[27179]: Incoming packet: fa52fb
Jul 14 13:08:19 mcp node[27179]: =============================
Jul 14 13:08:19 mcp node[27179]: Bad CRC 65535 vs NaN
Jul 14 13:08:19 mcp node[27179]: =============================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants