From 5746b759bf0651227440849ff7bb6564e50b8938 Mon Sep 17 00:00:00 2001 From: Adam Grare Date: Mon, 30 Sep 2024 14:42:08 -0400 Subject: [PATCH] Remove useless Dir.chdir in Terraform::Runner Dir.glob returns full file pathnames that have the dir_path stipped before adding to the zipfile anyway so the Dir.chdir is entirely useless here. --- lib/terraform/runner.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/terraform/runner.rb b/lib/terraform/runner.rb index 0d90223..fe9f716 100644 --- a/lib/terraform/runner.rb +++ b/lib/terraform/runner.rb @@ -170,8 +170,7 @@ def encoded_zip_from_directory(template_path) Tempfile.create(%w[opentofu-runner-payload .zip]) do |zip_file_path| _log.debug("Create #{zip_file_path}") Zip::File.open(zip_file_path, Zip::File::CREATE) do |zipfile| - Dir.chdir(dir_path) - Dir.glob("**/*").select { |fn| File.file?(fn) }.each do |file| + Dir.glob(File.join(dir_path, "/**/*")).select { |fn| File.file?(fn) }.each do |file| _log.debug("Adding #{file}") zipfile.add(file.sub("#{dir_path}/", ''), file) end