-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scramsha migration test failures on rails 7.1 #768
Comments
cc @bdunne |
jrafanie
added a commit
to jrafanie/manageiq-schema
that referenced
this issue
Dec 12, 2024
In rails 7.0, it's called 10 times plus 1 more on the next line. In rails 7.1+, it's called only once. From a test perspective, we don't care if it's even called. We only care that the SQL query is executed with the scramsha password or not. With this, I believe we can expect test success on rails 7.1 and 7.2. It was added in 742841c but I think this change emphasizes what we really care about testing and removes an assertion on internals that we don't really have interest in testing. Fixes ManageIQ#768
jrafanie
added a commit
to jrafanie/manageiq-schema
that referenced
this issue
Dec 12, 2024
In rails 7.0, it's called 10 times plus 1 more on the next line. In rails 7.1+, it's called only once. From a test perspective, we don't care if it's even called. We only care that the SQL query is executed with the scramsha password or not. To change the username/password only in calls from the migration itself and not from rails, we hack around the caller_locations to make the change only for the migration callers With this, I believe we can expect test success on rails 7.1 and 7.2. It was added in 742841c but I think this change emphasizes what we really care about testing and removes an assertion on internals that we don't really have interest in testing. Fixes ManageIQ#768
jrafanie
added a commit
to jrafanie/manageiq-schema
that referenced
this issue
Dec 12, 2024
In rails 7.0, it's called 10 times plus 1 more on the next line. In rails 7.1+, it's called only once. From a test perspective, we don't care if it's even called. We only care that the SQL query is executed with the scramsha password or not. To change the username/password only in calls from the migration itself and not from rails, we hack around the caller_locations to make the change only for the migration callers. With this, I believe we can expect test success on rails 7.1 and 7.2. It was added in 742841c but I think this change emphasizes what we really care about testing and removes an assertion on internals that we don't really have interest in testing. Fixes ManageIQ#768
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From #767
Seen in #766
The text was updated successfully, but these errors were encountered: