-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move provider alert creation back to providers #1786
Comments
This issue has been automatically marked as stale because it has not been updated for at least 6 months. If you can still reproduce this issue on the current release or on Thank you for all your contributions! |
@h-kataria is this still a valid issue? If yes, lease remove the stale label. If not can you close. |
@bronaghs Can you please check if backend work mentioned in #1786 (comment) was done. |
@AlexanderZagaynov - can you take care of Harpreet's question? |
Looks like this provider alerts syncing feature all related to Hawkular (together with alert profiles, and many other places which can be found by Hawkular keyword). |
This issue has been automatically marked as stale because it has not been updated for at least 6 months. If you can still reproduce this issue on the current release or on Thank you for all your contributions! |
@agrare what are you thoughts on this one? |
related to ManageIQ/manageiq#19440 |
We no longer have a MiddlewareManager so this code can be deleted |
cc @djberg96 looks like we missed some hawkular/middleware_manager references in ui-classic |
@agrare I see hawkular references in:
Should those all be removed? |
@djberg96 Any reference to the Hawkular provider or MiddlewareManager should be removed. |
The
alert_sync_provider
method should be changed to ask whether the provider supports creating "provider alerts", and if so, ask the provider to create the alert.See:
manageiq-ui-classic/app/controllers/miq_policy_controller/alerts.rb
Lines 676 to 681 in 00a3faf
Requires backend work to provide "supports create_provider_alert feature", and common API to create the alert on providers.
The text was updated successfully, but these errors were encountered: