Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move provider alert creation back to providers #1786

Closed
blomquisg opened this issue Jul 28, 2017 · 12 comments
Closed

Move provider alert creation back to providers #1786

blomquisg opened this issue Jul 28, 2017 · 12 comments

Comments

@blomquisg
Copy link
Member

blomquisg commented Jul 28, 2017

The alert_sync_provider method should be changed to ask whether the provider supports creating "provider alerts", and if so, ask the provider to create the alert.

See:

if @alert.db == "MiddlewareServer"
MiqQueue.put(
:class_name => "ManageIQ::Providers::Hawkular::MiddlewareManager",
:method_name => "update_alert",
:args => {:operation => operation, :alert => @alert}
)

Requires backend work to provide "supports create_provider_alert feature", and common API to create the alert on providers.

@miq-bot
Copy link
Member

miq-bot commented Feb 5, 2018

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@miq-bot miq-bot added the stale label Feb 5, 2018
@JPrause
Copy link
Member

JPrause commented Jan 28, 2019

@h-kataria is this still a valid issue? If yes, lease remove the stale label. If not can you close.
If there's no update by next week, I'll be closing this issue.

@h-kataria
Copy link
Contributor

@bronaghs Can you please check if backend work mentioned in #1786 (comment) was done.

@bronaghs
Copy link

@AlexanderZagaynov - can you take care of Harpreet's question?

@AlexanderZagaynov
Copy link

Looks like this provider alerts syncing feature all related to Hawkular (together with alert profiles, and many other places which can be found by Hawkular keyword).
As I understood, we didn't support Hawkular after G-release.
So, it maybe makes sense to remove all those related code pieces instead of implementing supports? feature for provider alerts.

@miq-bot
Copy link
Member

miq-bot commented Aug 5, 2019

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@mfeifer
Copy link
Contributor

mfeifer commented Dec 13, 2019

@agrare what are you thoughts on this one?

@mfeifer
Copy link
Contributor

mfeifer commented Dec 13, 2019

related to ManageIQ/manageiq#19440

@agrare
Copy link
Member

agrare commented Dec 13, 2019

We no longer have a MiddlewareManager so this code can be deleted

@agrare
Copy link
Member

agrare commented Dec 13, 2019

cc @djberg96 looks like we missed some hawkular/middleware_manager references in ui-classic

@djberg96
Copy link
Contributor

djberg96 commented Dec 13, 2019

@agrare I see hawkular references in:

  • app/controllers/container_dashboard_controller.rb
  • app/controllers/mixins/ems_common.rb
  • app/controllers/mixins/ems_common/angular.rb
  • app/controllers/ems_container_controller.rb
  • app/controllers/miq_policy_controller/alert_profiles.rb
  • app/controllers/miq_policy_controller/alerts.rb

Should those all be removed?

@agrare
Copy link
Member

agrare commented Dec 16, 2019

@djberg96 Any reference to the Hawkular provider or MiddlewareManager should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants