Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery names to be relocated to other repo(s) #2529

Closed
gildub opened this issue Oct 27, 2017 · 8 comments
Closed

Discovery names to be relocated to other repo(s) #2529

gildub opened this issue Oct 27, 2017 · 8 comments

Comments

@gildub
Copy link
Contributor

gildub commented Oct 27, 2017

I believe the list of discovery types in [1] to be relocated to https://github.com/ManageIQ/manageiq.
The first reason is to be DRY as part of that information is also defined in [2] although more consolidation would be needed. Another driver would for future UI modularity.

Ultimately such meta data information might be better living under their respective providers.

[1] https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/helpers/application_helper/discover.rb#L4-L17
[2] https://github.com/ManageIQ/manageiq/blob/master/app/models/host.rb#L15-L23

@miq-bot
Copy link
Member

miq-bot commented Apr 30, 2018

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@miq-bot miq-bot added the stale label Apr 30, 2018
@JPrause
Copy link
Member

JPrause commented Jan 28, 2019

@gildub is this still a valid issue? If yes, lease remove the stale label. If not can you close.
If there's no update by next week, I'll be closing this issue.

@gildub
Copy link
Contributor Author

gildub commented Feb 5, 2019

@JPrause, well I'm not sure who's going to work on that one, not a blocker but such coupling is bad on the long term.

@JPrause
Copy link
Member

JPrause commented Feb 5, 2019

@gildub I'll remove the stale label for now.
Thanks for the update.
@miq-bot remove_label stale

@miq-bot miq-bot removed the stale label Feb 5, 2019
@miq-bot
Copy link
Member

miq-bot commented Aug 12, 2019

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@miq-bot miq-bot added the stale label Aug 12, 2019
@mfeifer
Copy link
Contributor

mfeifer commented Dec 13, 2019

related to ManageIQ/manageiq#19440

cc @agrare

@miq-bot
Copy link
Member

miq-bot commented Jun 11, 2020

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

@agrare
Copy link
Member

agrare commented Jun 29, 2020

Added as a checklist item to ManageIQ/manageiq#19440

@agrare agrare closed this as completed Jun 29, 2020
@Fryguy Fryguy removed the stale label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants