Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: Make the main menu accessible #7358

Closed
6 tasks done
skateman opened this issue Sep 30, 2020 · 1 comment
Closed
6 tasks done

a11y: Make the main menu accessible #7358

skateman opened this issue Sep 30, 2020 · 1 comment

Comments

@skateman
Copy link
Member

skateman commented Sep 30, 2020

Keyboard navigation:

After all these are done, I think we should do a little cleanup.

@skateman
Copy link
Member Author

skateman commented Oct 2, 2020

@kavyanekkalapu you mentioned on the last meeting that the second level of the menu is not accessible, this is not completely true, the problem is that it is accessible only after going through all the elements in the first level. This is because the second level isn't interleaving into the existing menu structure, but we create a new one. The straightforward solution would be to have a nested markup and sort out the styling to look like it looks now, but I'm not sure if it's doable.

This would also make the hiding the second level easier, because it's easier to deal with onFocus back to the first menu than to onBlur to anything else 😕

cc @himdel and maybe @Ashley-Johnson28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants