Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Redesign MiqServer Worker Management #20424

Closed
1 task
agrare opened this issue Aug 10, 2020 · 2 comments
Closed
1 task

[RFE] Redesign MiqServer Worker Management #20424

agrare opened this issue Aug 10, 2020 · 2 comments

Comments

@agrare
Copy link
Member

agrare commented Aug 10, 2020

The current MiqServer::WorkerManagement was originally developed around starting worker processes on appliances, and a lot of logic for actually starting and stopping workers is handled in the MiqWorker class rather than in the MiqServer::WorkerManagement module.

With the addition of the "podified" runtime the way that workers are started and stopped was conditional and some checks had to be added throughout the code. Adding the systemd runtime compounded this with even more conditional checks.

A cleaner design would be to consolidate the worker management logic into a common interface that has the worker operations like start/stop/restart implemented by subclasses like Container/Systemd/Process. The MiqWorker class can then only be responsible for the name, count, and env vars/config without any special consideration for if they'll be run k8s or systemd.

TODO

@miq-bot
Copy link
Member

miq-bot commented Mar 6, 2023

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@agrare
Copy link
Member Author

agrare commented Mar 7, 2023

This was actually implemented #21508

@agrare agrare closed this as completed Mar 7, 2023
@agrare agrare removed the stale label Mar 7, 2023
@Fryguy Fryguy added this to Roadmap Jun 12, 2024
@Fryguy Fryguy moved this to Najdorf in Roadmap Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Najdorf
Development

No branches or pull requests

4 participants