Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to ruby 3.1 #22696

Closed
25 tasks done
jrafanie opened this issue Sep 8, 2023 · 0 comments
Closed
25 tasks done

Upgrade to ruby 3.1 #22696

jrafanie opened this issue Sep 8, 2023 · 0 comments
Assignees
@jrafanie
Labels
dependencies enhancement pinned ruby3.1
Milestone
Radjabov

Comments

@jrafanie
Copy link
Member

jrafanie commented Sep 8, 2023 •
edited
Loading

image

Ruby 3.0
status: security maintenance
release date: 2020-12-25
normal maintenance until: 2023-04-01
EOL: 2024-03-31 (expected)

FROM: https://www.ruby-lang.org/en/downloads/branches/

TODO:
@jrafanie jrafanie self-assigned this Sep 8, 2023
@Fryguy Fryguy added this to the Quinteros milestone Sep 8, 2023
@jrafanie jrafanie mentioned this issue Sep 11, 2023
Merged
7 tasks
jrafanie added a commit to jrafanie/manageiq that referenced this issue Sep 13, 2023
@jrafanie
net/ftp was moved out of standard library to a gem in ruby 3.1
2bbcd5d 
Extracted from ManageIQ#22698
Part of ManageIQ#22696

See: rails/rails#45816
https://www.ruby-lang.org/en/news/2021/12/25/ruby-3-1-0-released/

FileDepotFtp depends on this gem so it should be a dependency in core.
@jrafanie jrafanie mentioned this issue Sep 13, 2023
Merged
jrafanie added a commit to jrafanie/manageiq-gems-pending that referenced this issue Sep 14, 2023
@jrafanie
Ruby 3.1 - net/ftp was moved from stdlib to a gem
a6e76bb 
See: rails/rails#45816
https://www.ruby-lang.org/en/news/2021/12/25/ruby-3-1-0-released/

Related: ManageIQ/manageiq#22702
Part of: ManageIQ/manageiq#22696
@jrafanie jrafanie mentioned this issue Sep 14, 2023
Merged
jrafanie added a commit to jrafanie/manageiq-gems-pending that referenced this issue Sep 14, 2023
@jrafanie
Ruby 3.1 - net/ftp was moved from stdlib to a gem
1e7a75d 
See: rails/rails#45816
https://www.ruby-lang.org/en/news/2021/12/25/ruby-3-1-0-released/

Related: ManageIQ/manageiq#22702
Part of: ManageIQ/manageiq#22696
jrafanie added a commit to jrafanie/manageiq-password that referenced this issue Oct 12, 2023
@jrafanie
Add support for ruby 3.1's psych 4 default of safe_load
1699605 
Technically, we could use safe_load_file but that was added in psych 3.2.1, see:
ruby/psych@0210e31

It's easy enough to maintain 2.7 support by implementing it using File.read plus
safe_load without making a dependency change.

We can switch when we drop ruby 2.7 as 3.0 defaults to psych 3.3.x+.

Add Time field to the test v2_key to verify it's broken with ruby 3.1 before this change
and works after.

Part of ManageIQ/manageiq#22696
@jrafanie jrafanie mentioned this issue Oct 12, 2023
Merged
jrafanie added a commit to jrafanie/manageiq-schema that referenced this issue Oct 12, 2023
@jrafanie
Update stubs to work with manageiq-password 1.2.0+
bd94843 
The new gem uses File.read and we were stubbing File.read here, so we need
to be more precise in what we stub so we're now targetting just the migration
class's implementation of reading the file.

Part of ManageIQ/manageiq#22696
jrafanie added a commit to jrafanie/manageiq-schema that referenced this issue Oct 12, 2023
@jrafanie
For tests, use YAML.unsafe load in psych 4+
1c24b62 
Part of ManageIQ/manageiq#22696
@jrafanie jrafanie mentioned this issue Oct 12, 2023
Merged
jrafanie added a commit to jrafanie/manageiq-schema that referenced this issue Oct 12, 2023
@jrafanie
Update stubs to work with manageiq-password 1.2.0+
c917be2 
The new gem uses File.read and we were stubbing File.read here, so we need
to be more precise in what we stub so we're now targetting just the migration
class's implementation of reading the file.

Part of ManageIQ/manageiq#22696
jrafanie added a commit to jrafanie/manageiq-schema that referenced this issue Oct 12, 2023
@jrafanie
For tests, use YAML.unsafe load in psych 4+
72a63ef 
Part of ManageIQ/manageiq#22696
jrafanie added a commit to jrafanie/manageiq-schema that referenced this issue Oct 13, 2023
@jrafanie
For tests, use YAML.unsafe load in psych 4+
d38a7c6 
Part of ManageIQ/manageiq#22696
jrafanie added a commit to jrafanie/manageiq-automation_engine that referenced this issue Nov 14, 2023
@jrafanie
Update safe_load calls to work with psych 3/4
bd4c162 
Part of ManageIQ/manageiq#22696
jrafanie added a commit to jrafanie/manageiq-automation_engine that referenced this issue Nov 14, 2023
@jrafanie
Support psych 4 safe_load default with yaml_column_permitted_classes
20e1375 
Part of ManageIQ/manageiq#22696
jrafanie added a commit to jrafanie/manageiq-automation_engine that referenced this issue Nov 14, 2023
@jrafanie
Update safe_load calls to work with psych 3/4
109c29d 
Part of ManageIQ/manageiq#22696

Keep compatibility with psych 3.1+ since permitted_classes and aliases were
added as keyword arguments to safe_load.

Note, psych 4 changed the interface to drop support with positional arguments for the permitted_classes.
Now, we must explicitly specify them using kwargs.
jrafanie added a commit to jrafanie/manageiq-automation_engine that referenced this issue Nov 14, 2023
@jrafanie
Support psych 4 safe_load default with yaml_column_permitted_classes
ed33313 
Part of ManageIQ/manageiq#22696
jrafanie added a commit to jrafanie/manageiq-providers-amazon that referenced this issue Nov 14, 2023
@jrafanie
Update safe_load calls to work with psych 3/4
44d5263 
Part of ManageIQ/manageiq#22696

Keep compatibility with psych 3.1+ since permitted_classes and aliases were
added as keyword arguments to safe_load.

Note, psych 4 changed the interface to drop support with positional arguments for the permitted_classes.
Now, we must explicitly specify them using kwargs.
This was referenced Nov 14, 2023
Merged
Merged
jrafanie added a commit to jrafanie/manageiq-providers-kubevirt that referenced this issue Nov 15, 2023
@jrafanie
Update safe_load calls to work with psych 3/4
a2e3bc4 
Part of ManageIQ/manageiq#22696

Keep compatibility with psych 3.1+ since permitted_classes and aliases were
added as keyword arguments to safe_load.

Note, psych 4 changed the interface to drop support with positional arguments for the permitted_classes.
Now, we must explicitly specify them using kwargs.
@jrafanie jrafanie mentioned this issue Nov 16, 2023
Merged
jrafanie added a commit to jrafanie/manageiq-providers-red_hat_virtualization that referenced this issue Nov 16, 2023
@jrafanie
Use unsafe_load to load a test file with unpermitted classes
35d47c4 
Part of ManageIQ/manageiq#22696
@jrafanie jrafanie mentioned this issue Nov 16, 2023
Merged
jrafanie added a commit to jrafanie/manageiq-providers-ovirt that referenced this issue Nov 16, 2023
@jrafanie
Use unsafe_load to load a test file with unpermitted classes
f41e18e 
Part of ManageIQ/manageiq#22696
@jrafanie jrafanie mentioned this issue Nov 16, 2023
Merged
jrafanie added a commit to jrafanie/manageiq-ui-classic that referenced this issue Nov 17, 2023
@jrafanie
Permit subscription classes to be serialized in queue args
e228bd8 
Part of ManageIQ/manageiq#22696
jrafanie added a commit to jrafanie/manageiq-providers-kubernetes that referenced this issue Nov 17, 2023
@jrafanie
We explicitly serialize objects so we need to permit yaml loading them
01424e8 
Part of ManageIQ/manageiq#22696
This was referenced Nov 17, 2023
Merged
Open
jrafanie added a commit to jrafanie/manageiq-appliance-build that referenced this issue Dec 1, 2023
@jrafanie
Use el8/9 epel qpid proton 0.37.0+
698465e 
Undo ManageIQ#409 now that
we're ready to use the upstream packages in el8 or el9 epel qpid proton 0.37.0+

To be merged with ManageIQ/manageiq#22271
Prerequisite to ManageIQ/manageiq#22698
Needed for ManageIQ/manageiq#22696
@jrafanie jrafanie mentioned this issue Dec 1, 2023
Merged
jrafanie added a commit to jrafanie/manageiq that referenced this issue Dec 8, 2023
@jrafanie
Add ruby 3.1 to test matrix
5561991 
Followup to ManageIQ#22698
Part of ManageIQ#22696
@jrafanie jrafanie mentioned this issue Dec 8, 2023
Merged
3 tasks
jrafanie added a commit to jrafanie/manageiq that referenced this issue Dec 8, 2023
@jrafanie
Add ruby 3.1 to test matrix
ce27617 
Followup to ManageIQ#22698
Part of ManageIQ#22696
jrafanie added a commit to jrafanie/manageiq that referenced this issue Dec 18, 2023
@jrafanie
Add ruby 3.1 to test matrix
0dcda02 
Followup to ManageIQ#22698
Part of ManageIQ#22696
jrafanie added a commit to jrafanie/manageiq that referenced this issue Dec 18, 2023
@jrafanie
Add ruby 3.1 to test matrix
dd31926 
Followup to ManageIQ#22698
Part of ManageIQ#22696
jrafanie added a commit to jrafanie/manageiq-rpm_build that referenced this issue Dec 18, 2023
@jrafanie
Use ruby 3.1 and latest qpid_proton, 0.37.0
e3b63b6 
The latest epel8/9 has qpid_proton 0.37.0+ that works with ruby 3.1.

Part of ManageIQ/manageiq#22696
jrafanie added a commit to jrafanie/manageiq-rpm_build that referenced this issue Dec 18, 2023
@jrafanie
Drop hopefully no longer needed qpid_proton sources
151f2dc 
Part of ManageIQ/manageiq#22696
jrafanie added a commit to jrafanie/manageiq-rpm_build that referenced this issue Dec 18, 2023
@jrafanie
Drop qpid-proton-c if we're installing gem from epel rpm
b44c3e4 
Not sure if this was needed as a BuildRequire or a Require.  Hopefully, we can drop this.

Part of ManageIQ/manageiq#22696
@jrafanie jrafanie mentioned this issue Dec 18, 2023
Merged
jrafanie added a commit to jrafanie/manageiq-rpm_build that referenced this issue Jan 3, 2024
@jrafanie
Drop hopefully no longer needed qpid_proton sources
168b547 
Part of ManageIQ/manageiq#22696
jrafanie added a commit to jrafanie/manageiq that referenced this issue Jan 3, 2024
@jrafanie
Add ruby 3.1 to test matrix
915d964 
Followup to ManageIQ#22698
Part of ManageIQ#22696
bdunne added a commit to bdunne/manageiq-pods that referenced this issue Jan 24, 2024
@bdunne
Upgrade to ruby:3.1
05089a3 
Part of: ManageIQ/manageiq#22696
@bdunne bdunne mentioned this issue Jan 24, 2024
Merged
@Fryguy Fryguy modified the milestones: Quinteros, Radjabov Feb 21, 2024
@jrafanie jrafanie closed this as completed Mar 5, 2024
@Fryguy Fryguy added this to Roadmap Jun 12, 2024
@Fryguy Fryguy moved this to Radjabov in Roadmap Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrafanie jrafanie

Labels
dependencies enhancement pinned ruby3.1
Projects
Roadmap
Status: Radjabov
Milestone
Radjabov
Development

No branches or pull requests
2 participants
@jrafanie @Fryguy