Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider Validation missing zone_id from verify_credentials args #22845

Closed
15 tasks done
agrare opened this issue Jan 22, 2024 · 0 comments
Closed
15 tasks done

Provider Validation missing zone_id from verify_credentials args #22845

agrare opened this issue Jan 22, 2024 · 0 comments

Comments

@agrare
Copy link
Member

agrare commented Jan 22, 2024

A number of providers have params_for_create defined without zone_id listed in the validationDependencies for the validate-provider-credentials component.

This means that the user selected zone is not passed in to the verify_credentials method, this means that any worker with ems_operations on any zone can pick the queue item up. This will "work" unless you actually have network separation between your zones in which case the verify_credentials method will fail if it is picked up by a worker in another zone.

Example of a bad MiqQueue.put
[----] I, [2024-01-22T11:14:15.460520#98264:5bbd0] INFO -- evm: MIQ(MiqQueue.put) Message id: [5611], Zone: [], Role: [ems_operations], Server: [], MiqTask id: [69], Handler id: [], Ident: [generic], Target id: [], Instance id: [], Task id: [], Command: [ManageIQ::Providers::IbmPowerVc::CloudManager.verify_credentials?], Timeout: [600], Priority: [100], State: [ready], Deliver On: [], Data: [], Args: [{"endpoints"=>{"default"=>{"security_protocol"=>"ssl-no-validation", "hostname"=>"10.2.2.99", "port"=>5000}}, "authentications"=>{"default"=>{"userid"=>"admin", "password"=>"********"}}, "name"=>"powervc", "type"=>"ManageIQ::Providers::IbmPowerVc::CloudManager", "api_version"=>"v3", "provider_region"=>nil, "uid_ems"=>"default", :task_id=>69}]

Here you can see Zone: []

Providers impacted:

@agrare agrare self-assigned this Jan 22, 2024
@agrare agrare closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants