Child service link does not work on parent service details page

[eggoide]

Hello,

we are experiencing the following problem after upgrading from Najdorf to petrosian-1.20230912222549_a07cb46

If there is a service, that has its child service, the link to the child service does not work. On the parent service detail page, if you click on the child service to see the details, the link is just wrong.
The example link to the child service looks like this:
https://<miq_instance>/service/tree_select/?id=s-50115

(here is the log from apache access log file: 10.92.245.92 - - [07/Jun/2024:08:30:00 +0200] "GET /service/tree_select/?id=s-50115 HTTP/1.1" 404 728 )

The standard link to the child service works fine - https://<miq_instance>/service/show/50115#/

Is this a known bug or is there any workaround? Thank you

The environment is petrosian-1.20230912222549_a07cb46 running in Docker container connected to PostreSQL DB.

[Fryguy]

@jeffbonson Can you please take a look at this one.

[jeffbonson]

hey @eggoide , if possible, could you please give us the steps on how to replicate this issue in petrosian so that it makes it easier for us to debugg. a few scrrenshots or a screen recording would do.

[jeffbonson]

Findings -

I checked out petrosian branch, but this issue could be in master branch as well.

I didn't have a child service configured in my local env. Probably thats why it went unnoticed during the conversion process.

Earlier, this was an explorer page, and the click event is supposed to be loading the right hand side of the explorer page.
will need to see a way on how to redirect this..

However, @eggoide , if you still have the steps on how to do it, please do share it over here.

[eggoide]

Hi, here go the steps i have taken to reporoduce it.
I started the petrosian docker container to have completely clean installation of ManageIQ.

I created 2 services:
test_catalog_item-20240613-134246
test_catalog_item-20240613-134517

In rails console, I set test_catalog_item-20240613-134246 to be child service of test_catalog_item-20240613-134517

Then in ManageIQ UI, I opened the parent service:

When I click on the child service, the progress rotates but nothing happens. The URL is bad:

The proper URL should probably be service/show/1

I hope it clarifies the approach.

[jeffbonson]

Fixes - ManageIQ/manageiq-ui-classic#9207

[eggoide]

@jeffbonson Thank you for the fix. Will the commit be also included in the Petrosian docker image - possible rebuild?

[jeffbonson]

@jeffbonson Thank you for the fix. Will the commit be also included in the Petrosian docker image - possible rebuild?

cc @Fryguy

[eggoide]

@jeffbonson Hi, I checked the fix however, I dont think it works. Correct me please if I am doing something wrong.
I updateded service_helper.rb

and _svcs_show.html.haml

After restart of ManageIQ , the child link does nothing, no activity in debug console.

[jeffbonson]

Hey @eggoide , thats weird.

I can see you have applied the changes and the new react component is being rendered.

Here is what is see in my local env

I am clicking on the the child row and it redirects me to a new service summary page

Screen.Recording.2024-06-14.at.4.42.44.PM.mov

[eggoide]

@jeffbonson I tried it on two different environments. One clean just to test the fix and one that servers as our main environment. Both behave the same. If I can test anything else for you, I will do it.

[jeffbonson]

Found the issue.

A lot of code refactoring happend after petrosian. so, moving this code to petrosian wont work. Thanks for testing it out early.

could you try changing this line below in the service_helper.rb

:cells => [{:icon => 'pficon pficon-service', :value => service.name, :link => "/service/show/#{service.id}"}],

[eggoide]

@jeffbonson This modification works! Thank you

[jeffbonson]

• Fix forpetrosian - [petrosian] Fix child service links manageiq-ui-classic#9209
• Fix for master - Fix child services link manageiq-ui-classic#9207

[GilbertCherrie]

@eggoide Unfortunately the Petrosian branch is no longer supported and we do not release any updates for it so the Petrosian pr can not be merged. If you want this fix it would have to be done locally

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.