Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in fields naming #268

Open
samitnuk opened this issue Feb 11, 2021 · 1 comment
Open

Inconsistency in fields naming #268

samitnuk opened this issue Feb 11, 2021 · 1 comment

Comments

@samitnuk
Copy link

The snake_case is used mostly for all field names in the resources.py. But for some fields the lowerCamelCase is used for some reason.

E.g.:

class Document(KYC):
user = ForeignKeyField(User, related_name='documents', api_name='UserId')
type = CharField(api_name='Type', choices=constants.DOCUMENTS_TYPE_CHOICES, default=None)
status = CharField(api_name='Status', choices=constants.DOCUMENTS_STATUS_CHOICES, default=None)
refused_reason_type = CharField(api_name='RefusedReasonType')
refused_reason_message = CharField(api_name='RefusedReasonMessage')
processedDate = DateTimeField(api_name='ProcessedDate')

processedDate ^

class Ubo(BaseModel):
first_name = CharField(api_name='FirstName', required=True)
last_name = CharField(api_name='LastName', required=True)
address = AddressField(api_name='Address', required=True)
nationality = CharField(api_name='Nationality', required=True)
birthday = DateField(api_name='Birthday', required=True)
birthplace = BirthplaceField(api_name='Birthplace', required=True)
user = ForeignKeyField(User)
ubo_declaration = ForeignKeyField(UboDeclaration)
isActive = BooleanField(api_name='IsActive')

isActive ^

@fredericdelordm
Copy link

Hello @samitnuk,

Thank you for your suggestion. We are reviewing it.

Have a nice day,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants