Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing #343

Open
FractalWire opened this issue Nov 3, 2023 · 1 comment
Open

Tests are failing #343

FractalWire opened this issue Nov 3, 2023 · 1 comment

Comments

@FractalWire
Copy link

Hello,

I'm trying to upgrade the sdk to the last version but the tests are failing.
It look like it fails on your pipeline but also locally when I launch tox.

18 errors and 1 failure.

Also, the python version that tox use for the tests are deprecated (2.7, 3.4).
Hence, I was not able to test against those and modified tox to test with the python version we currently use (3.8).

I recommand testing version 3.8 and onward instead of the very deprecated 3.4.

Finally, I had to add this line in tox.ini for tox to lauch:

...
[testenv]
allowlist_externals = make
...

Thanks

@FractalWire
Copy link
Author

I was able to reduce the number of error to 6 by unpinning response in requirements/development.txt like so:

responses>=0.18.0

You might avoid the issue with earlier version of it.

Also, please, do not pin your dependencies as it makes this sdk more difficult to integrate for us and specify a range of compatible version instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant