Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light Mode Bug #249

Open
timea-techgirl opened this issue Apr 4, 2024 · 7 comments
Open

Light Mode Bug #249

timea-techgirl opened this issue Apr 4, 2024 · 7 comments
Labels
question Further information is requested

Comments

@timea-techgirl
Copy link

Describe the bug
Light mode title bar is dark, for example notepad.

To Reproduce
Just install v2.1.1
Open notepad and the title bar is not light
This issue doesn't occur is 2.0.1

Screenshots
image

Additional information:

OS Version : Windows 10 LTSC 2021 21H2.19044.4170
Software Version : 2.1.1

What other third-party software do you use:
None

@timea-techgirl timea-techgirl added the question Further information is requested label Apr 4, 2024
@Maplespe
Copy link
Owner

This is actually normal Light mode, no problem.
The text and button glyphs in Dark mode are white.

@timea-techgirl
Copy link
Author

timea-techgirl commented Apr 26, 2024

No, the preview shows it correctly. The titlebar is light in the previous version. I'm not talking about the titlebar text but the colour of the bar itself.
image

image

As you can see, the titlebar is light. In v2.0.1, it was perfect. Now, the titlebar is dark in light mode.

@valkalyne
Copy link

valkalyne commented May 15, 2024

i think what's happening here is that the blend mode for the regular blur effect method is set wrong maybe
ive tested this with 2.0.1 and 2.2.0 with the exact same colour values using the blur effect
qworng
i think whats happening is that its using the multiply blend so when you set your titlebar colour to white its like nothing is happening at all

i dont think its a light mode bug i think its just a shader bug

@timea-techgirl
Copy link
Author

Describe the bug Light mode title bar is dark, for example notepad.

To Reproduce Just install v2.1.1 Open notepad and the title bar is not light This issue doesn't occur is 2.0.1

Screenshots image

Additional information:

OS Version : Windows 10 LTSC 2021 21H2.19044.4170
Software Version : 2.1.1

What other third-party software do you use: None

I found out that this bug occurs only when I select Aero from DWMBlurGlass > Advanced > Effect Type.

To reproduce,

  • Windows theme setting must be Dark.
  • Open notepad and then and change the setting in DWMBlurGlass -> Advanced -> Effect Type from the default Blur to Aero and the titlebar colour of notepad changes to dark.

@Maplespe
Copy link
Owner

The aero shader of 2.0.1 is different from 2.2.0+.
The aero shader of 2.2.0+ is modeled after Window 7's Aero effect 1:1
Whereas 2.0.1's aero effect is just an exposure effect, it is not correct.
Also The preview image is for reference only, if you use the aero effect, various parameters of aero such as color balance, blur balance, glow balance will result in a different effect This is not visible in the preview image.
The Alpha channel of the color values will affect the effect of the color balance.

So this is not a bug, it's just an update to make it closer to the real Window 7 aero effect.
Here's more detailed info:#269

@timea-techgirl
Copy link
Author

I have never seen this in Windows 7 which I used for a long time. It's not about the preview. It just doesn't look right. It should be light, not dark.

@Maplespe
Copy link
Owner

First of all Windows 7 doesn't have Dark mode at all.
Also Light colors and Dark colors are set separately.
If you use the system Accent color, only Alpha is valid for the color in DWMBlurGlass.
Increase the alpha value or even set it to 100%.
Also The other parameters should be adjusted to match your colors, especially the color balance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants