Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loss of focus on feature pop up #1024

Open
AliyanH opened this issue Jan 29, 2025 · 0 comments · May be fixed by #1029
Open

Loss of focus on feature pop up #1024

AliyanH opened this issue Jan 29, 2025 · 0 comments · May be fixed by #1029

Comments

@AliyanH
Copy link
Member

AliyanH commented Jan 29, 2025

When you tab into a feature pop up, if you keep pressing tab the focus will exit out of the pop up rather than going back to the first element.

When you tab into the "zoom to here" link and press shift-tab, the popup loses focus and the focus is shifted to the feature itself.

This is a bug in how focus is managed withn the feature popup (aka button). The tab / shift+tab keys should move around the popup controls but never exit the popup. You should only exit the popup when you dismiss it or press next/previous buttons in the popup controls. However we noticed that focus drifts outside the popup by accident. For example, steps to reproduce:

Load this page
Tab to the first feature (tab x 2)
Hit enter to activate the popup
Tab x 1
Shift+Tab x 1
What you expect to happen: focus should be on the X (dismiss) button
What happens: focus returns to the feature, leaving the popup displayed

Originally posted by @prushforth in #163

@AliyanH AliyanH linked a pull request Feb 6, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant