Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt the actions-rust-lang/setup-rust-toolchain action #1832

Open
2 tasks
MarcoIeni opened this issue Nov 12, 2024 · 1 comment
Open
2 tasks

Adopt the actions-rust-lang/setup-rust-toolchain action #1832

MarcoIeni opened this issue Nov 12, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MarcoIeni
Copy link
Owner

MarcoIeni commented Nov 12, 2024

Motivations

https://github.com/actions-rust-lang/setup-rust-toolchain

At the moment we use https://github.com/dtolnay/rust-toolchain which has less features. E.g. it misses caching, rust-toolchain file support, you can't pin the commit and there's no problem matcher.

Solution

Do two separate PRs:

  • Change the action for release-plz ci. In this case, pin the action to the latest commit sha. We will use renovate to keep it up do date.
  • Change the action in the docs. In this case, use actions-rust-lang/setup-rust-toolchain@v1. No need to pin the sha because people would use any approach they prefer. Specify that any way to install the toolchain works, but that this action setup the cache, so they would need to set it up automatically with rust-cache if they use another action.
@MarcoIeni MarcoIeni added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Nov 12, 2024
@Krishang91
Copy link

Hi,can you assign me this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants