Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PostsDataProvider #1

Open
MarcoSero opened this issue Jul 21, 2015 · 0 comments
Open

Refactor PostsDataProvider #1

MarcoSero opened this issue Jul 21, 2015 · 0 comments

Comments

@MarcoSero
Copy link
Owner

PostsDataProvider.mm got too big and it has a lot of "RAC-Spaghetti" code and internal state.

Also, since ComponentKit does its layout asynchronously, after adding the new posts to the data source they are not rendered on screen, that means that isReachingBottomSignal will still emit YES.
We want to avoid fetching the content multiple times but at the same time we want to dismiss the loading indicator immediately, so that's why some additional internal state is kept as a BOOLs.

ComponentKit provides some facilities to fix this. See facebook/componentkit#307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant