Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAI toolchain: provide options for rate limiting #339

Open
mjordan opened this issue Mar 7, 2017 · 3 comments
Open

OAI toolchain: provide options for rate limiting #339

mjordan opened this issue Mar 7, 2017 · 3 comments

Comments

@mjordan
Copy link
Collaborator

mjordan commented Mar 7, 2017

The OAI-PMH harvester MIK uses, https://github.com/caseyamcl/phpoaipmh, doesn't provide any built-in rate limiting options like pausing, etc, but its README points out that https://github.com/guzzle/retry-subscriber can be used for this sort of thing. We should add rate-limiting options so brittle OAI-PMH providers don't crash as often when we point MIK at them.

@mjordan
Copy link
Collaborator Author

mjordan commented Mar 22, 2017

@bondjimbond can we close this since we have #344?

@bondjimbond
Copy link
Collaborator

The fix for #344 is related but different - but perhaps good enough for now? Are there other use cases for rate limiting specifically that aren't covered in #344?

@mjordan
Copy link
Collaborator Author

mjordan commented Mar 22, 2017

Fair enough - but AFAIK implementing this will be non-trivial since we'll need to dig into the OAI-PMN harvester. Let's leave it open in case someone gets the time to take a closer look.

I can't think of a more specific use case for rate limiting on the OAI harvest other than to not swamp the OAI provider, but as I understand it, the whole reason they included resumption tokens was to allow for a built-in rate limit, or at least, a limit on how many records were returned at one time. Fetching the files is outside the scope of OAI-PMH so I don't think that was a consideration when they thought about resumption tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants