Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Threads are not auto-deleted if the message is deleted after a few hours #326

Open
MarcusOtter opened this issue Oct 9, 2022 · 1 comment
Labels
potential bug 馃悰 Has not been replicated yet

Comments

@MarcusOtter
Copy link
Owner

Describe the bug

The auto-delete feature (#253) seems to work fine when the parent message is deleted immediately. However, if one waits for a few hours (probably 2-4h), the feature does not work, according to DoNotResuscitate on Discord.

This would make sense as Needle flushes the cache every 2-4 hours and you don't receive any events for messages that are not cached unless message partials are enabled (which they are not for Needle).

Steps to reproduce the bug

  1. Send a message in an auto-threaded channel
  2. Wait 4+ hours (maybe as little as 2 hours works, not sure exactly how long)
  3. Delete the message.
  4. See nothing happen.

Expected behavior

Needle should delete/archive the thread (depending on permissions and content in the thread).

@MarcusOtter MarcusOtter added the potential bug 馃悰 Has not been replicated yet label Oct 9, 2022
@MarcusOtter
Copy link
Owner Author

Working on reproducing the bug atm.

Not sure how feasible this is to fix since we need to enable partials, and I'm not sure how many bugs that's going to introduce & potentially a lot more traffic for Needle. Since nobody has noticed this bug for over a month I'm assuming this feature is mostly used by people that go "Oh, this isn't what I wanted" and immediately delete the thread (at least within a few hours).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential bug 馃悰 Has not been replicated yet
Projects
None yet
Development

No branches or pull requests

1 participant