Hi! I'm really excited that you are interested in contributing to @maj/react-ui. Before submitting your contribution, please make sure to take a moment and read through the following this guideline
- Always before opening a new PR, you need to create a new issue explaining the purpose of the PR.
-
Firstly you need to clone or fork this repository.
-
The main branch is just a snapshot of the latest stable release. All development should be done in dedicated branches. Do not submit PRs against the main branch.
-
Work in the src folder and DO NOT checkin dist in the commits.
-
It's OK to have multiple small commits as you work on the PR.
-
Make sure
npm run lint
oryarn run lint
passes in local and remote.
-
git pull --rebase origin dev
to ensure you have the latest dev code. -
git checkout -b type/the-name-of-branch
.- Replacing type with one of these:
docs
when your changes are related to documentation(README, CONTRIBUTING, ect...).feature
When your changes are related to new features and functionalities.fix
When your changes are related to fix any bug.
- Replacing
the-name-of-branch
with a suitable name.
- Replacing type with one of these:
- Write your code.
- Save all files and check in the real reactjs project.
- Run
yarn lint
ornpm run lint
from the project root. (This will run ESLint).
git add --all && git commit -m "My message"
(replacing My message with a commit message to stage and commit your changes).git push origin type/the-name-of-branch
to send your changes to the remote repo.- Go to the
@maj/react-ui
repo and you should see recently pushed branches. - Follow GitHub's instructions to open your branch.
- Add
description, code example, reviewrs, labels, assignees
. - wait for review from other contributors.