Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait For Request to return request payload #4003

Open
mekxtari opened this issue Jan 23, 2025 · 7 comments
Open

Wait For Request to return request payload #4003

mekxtari opened this issue Jan 23, 2025 · 7 comments
Labels
enhancement New feature or request priority: medium

Comments

@mekxtari
Copy link

Is your feature request related to a problem? Please describe.
I would like to verify request payload values.

Describe the solution you'd like
Maybe Wait For Request could return request payload.

Describe alternatives you've considered
By extending browser libary you can return request payload but
it would be nice to be included without extension.

Additional context

@aaltat
Copy link
Member

aaltat commented Jan 26, 2025

@allcontributors please add @mekxtari for ideas

Copy link
Contributor

@aaltat

@mekxtari already contributed before to ideas

@aaltat
Copy link
Member

aaltat commented Jan 26, 2025

Playwright supports this: https://playwright.dev/docs/api/class-request Could you be more specific what you are looking for?

@aaltat aaltat added enhancement New feature or request priority: medium labels Jan 26, 2025
@mekxtari
Copy link
Author

Few daya ago i received reply to my email account saying the following:

”Hello, we tried to solve the issue.

This is what we did:

Modified the wait_for_request keyword to include the request payload in the returned data. This allows users to verify request payload values without extending the library.

You can review changes in this commit: clarin-ebtio800090@e2e1591.”

So i believe this is already done and Wait For Request will return payload data in next released version?

@aaltat
Copy link
Member

aaltat commented Jan 28, 2025

Err, that link does not work and I don’t follow what you are saying. Could clarify what you are saying?

@mekxtari
Copy link
Author

Image

Had to check my email again and reply seemed to be from AI 😀 Commit link worked when i checked it and I thought someone had made the change i requested.

@aaltat
Copy link
Member

aaltat commented Jan 30, 2025

So can we close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: medium
Projects
None yet
Development

No branches or pull requests

3 participants
@aaltat @mekxtari and others