Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better typing support #943

Open
bhirsz opened this issue Aug 28, 2023 · 2 comments
Open

Better typing support #943

bhirsz opened this issue Aug 28, 2023 · 2 comments
Labels
refactor Changes that do not affect usage

Comments

@bhirsz
Copy link
Member

bhirsz commented Aug 28, 2023

Our code is partly typed but we miss most of the typing. We should add typing information to our code (or at least to most of it).

@mnojek mnojek added the refactor Changes that do not affect usage label Aug 29, 2023
@borutzki
Copy link

borutzki commented Feb 9, 2024

Do you see it as a project to be done in one PR or split into multiple ones?

Also, I am quite new here. Is there already a type checker selected for this project? Which way of adding type hints should be used?

I'm considering doing it as a side-job but probably it's better first to ask about that and only then start working on a whole repo.

@bhirsz
Copy link
Member Author

bhirsz commented Feb 10, 2024

Doesn't matter but considering the scope, it can be split into multiple parts so it's easier.

We don't use any, anything popular is fine - like mypy etc. It depends, we could start by fixing issues (like run mypy/any similar tool, catch problems and fix them) or add typing where it's needed the most. We need to have performance in mind - if we need to import whole new package to add typing, it's better to use "type in string" with flag that only import such package when typing check is performed. But other than that I don't have any special condition in mind and it certainly can be done by anyone who is willing to :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes that do not affect usage
Projects
None yet
Development

No branches or pull requests

3 participants