Weird behavior of should throw

[darmen]

Hi Markus!

I'm trying to do this:

    @Test
    fun `assert throws exceptions`() {
        invoking { factory.create("") } `should throw` IllegalArgumentException::class
    }

But have a compile error:

org/junit/ComparisonFailure
java.lang.NoClassDefFoundError: org/junit/ComparisonFailure
	at org.amshove.kluent.ExceptionsKt.shouldThrow(Exceptions.kt:14)
	at org.amshove.kluent.ExceptionsBacktickKt.should throw(ExceptionsBacktick.kt:5)
        ...

Do you have any clues?

[MarkusAmshove]

This looks like the the JUnit dependency for JVM isn't resolved.
Which Kluent and Kotlin versions are you using?
Any chance I can look into the project? e.g. is it open source or can you create a minimal repro?

[svenjacobs]

I'm having the same problem. The project uses Spek and not JUnit. I think Kluent should not have an implicit dependency on JUnit.

Maybe in shouldThrow() don't use ComparisonFailure explicitly but just check for the string name of the class?

[MarkusAmshove]

The dependency to JUnit is a known limitation at the moment, which I've got rid of (switched to kotlin.test) for the multiplatform branch.

The problem is, that using JUnit exceptions has better IDE integration (e.g. diff windows on comparison failures) which kotlin.test didn't do (at least at the time).

It might be worth to check out if this has been resolved in kotlin.test yet :-)

[fabianpiau]

I have the same error, my project is banning Junit 4 dependency, so can't use this type of assertion unfortunately. Can you make it work with Junit 5?

[MarkusAmshove]

The diff window for IntelliJ seems to also support formatting of the exception message, maybe we can build up on that.
The RegEx can be found here, although it has junit4 in the package name, so it needs to be tested if it works with something else than ComparisonFailure