Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Final] final project review #52

Open
vladyslav-yermolin-moc opened this issue Jul 2, 2024 · 0 comments
Open

[Final] final project review #52

vladyslav-yermolin-moc opened this issue Jul 2, 2024 · 0 comments

Comments

@vladyslav-yermolin-moc
Copy link
Collaborator

vladyslav-yermolin-moc commented Jul 2, 2024

Main repository - https://github.com/MastersAcademy/fe-react-2024
Design - https://www.figma.com/file/mRAOMdJiAsD8fHSVnYwUl9/React-web-page
Branch name (from which you will create a pr)- main
Branch name (to which you will create a pr)- task/10-final

This is the final review of your project by the support mentor.
You can send your project to review even if you haven't done all homeworks

1. Setup your branch for the final review

You should create a branch form origin/main(initial state of your repository) and make a pull-request to it. This is needed to see all the changes you made during the course.
1.1. Make sure, that main repository is added to your local machine as second remote

git remote -v
moc     [email protected]:MastersAcademy/fe-react-2024.git (fetch)
moc     [email protected]:MastersAcademy/fe-react-2024.git (push)
origin  [email protected]:vladyslav-yermolin-moc/fe-react-2024.git (fetch)
origin  [email protected]:vladyslav-yermolin-moc/fe-react-2024.git (push)

# if you don't see a moc remote simply add it
git remote add moc [email protected]:MastersAcademy/fe-react-2024.git

1.2. Create a new local branch task/10-final from the moc/main

git checkout -b task/10-final moc/main

1.3.Push this new local branch to your remote repository

git push origin

2. (Optional) Add some logic to your project.

2.1. Switch to main branch

git checkout main

2.2. Add logic from the design, which was not implemented during the course

  • Mobile menu
  • Cart page
  • Sign up form
  • Whatever you like to add

3. Send your project to review.

3.1. In your remote repository create a pull request from the main branch to task/10-final branch.
3.2. Add your support mentor from the table as reviewer. Add him to your project as collaborator, if you haven't done it yet.
3.3. In the description list the tasks which you implemented and which were not. Example:

Implemented:

  • About, Products, Product, Login pages
  • Theme switching and its storage in localStorage

Not Implemented

  • Redux
  • Api calls
  • Sign up and cart pages
@vladyslav-yermolin-moc vladyslav-yermolin-moc changed the title хї [Final] final project review Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant