Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Save view position between scene activations #115

Open
matt-derrick opened this issue Mar 4, 2024 · 3 comments
Open

[FEATURE] Save view position between scene activations #115

matt-derrick opened this issue Mar 4, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@matt-derrick
Copy link

Setup

  • OS: Windows 11
  • Browser: Chrome
  • Module version: 1.5.9
  • Foundry version: 11, Build 315
  • Gaming system & version: PF2e
  • Any other modules enabled: no

Describe the bug
When activating a scene, the position of the viewbox (after editing it) is reset to an undesired position.

Screenshots
I recorded a video of the issue: https://youtu.be/wXNYBA6MCiY

Console Log
no obvious errors in the console log.

Additional context
I've tried every combination of initial view and lock view settings and the bounding box set when using 'edit viewbox' is automatically reset anytime the DM activates a different scene.

@matt-derrick matt-derrick added the bug Something isn't working label Mar 4, 2024
@matt-derrick matt-derrick changed the title [BUG] [BUG] Activating any scene resets viewbox position Mar 4, 2024
@MaterialFoundry
Copy link
Owner

Unless there is something I'm missing, this is not a bug. The viewbox allows you to change the view of a player client, but this value is not stored somewhere for when the scene is reactivated.

When a scene is activated it does one of the following:

  • If there are no player controlled tokens present: go to the initial view position (this is core Foundry behavior)
  • If there is a player controlled token present: center on the token (this is core Foundry behavior)
  • If there is a player controlled token present but Lock View's 'Force Initial View' is enabled: go to the initial view position

As you can see, in none of these situations the view will actually return to what it was after reactivating a scene. While I'm sure there is a way to add this to the module, I don't think it'd be something I'd be adding anytime soon.

@matt-derrick
Copy link
Author

matt-derrick commented Mar 4, 2024

Hey there, thank you for your reply, and the excellent module, it's come in handy in a ton of games.

I guess I just expected/hoped that the position would be saved because of the scenario I'm facing with running Death House in the Curse of Strahd campaign:

I'm doing an live, in-person game with a TV table I built. I love how I can reposition the screen with the view box, it makes it much easier to get the look/scale right for the map I'm using. But, the players will also be going up and down the stairs quite a bit (therefore, switching scenes between each level of the house, I'm using monks tile triggers for this) and it would be incredibly handy to save the view box position per scene.

This way, I don't have to re-position it every time someone moves to a new floor and I activate the scene for that floor.

Based on your explanation above, I understand that the current setup is not a bug, so I guess this would be a feature request. If you'd like me to re-submit this as such, please let me know. I hope you'll reconsider adding this feature as I think it would really help in this situation and perhaps others.

Of course, if I'm totally overthinking this, and there is an easier way to keep the floors at the same position when switching scenes, please let me know. Thanks for your time!

@MaterialFoundry MaterialFoundry changed the title [BUG] Activating any scene resets viewbox position [FEATURE] Save view position between scene activations Mar 5, 2024
@MaterialFoundry MaterialFoundry added enhancement New feature or request and removed bug Something isn't working labels Mar 5, 2024
@MaterialFoundry
Copy link
Owner

I've turned this issue into a feature request.

I can see why it would be useful, but as I've said, I'm not sure when I'd be able to implement it, since I have a lot of things that are higher on my priorities list right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants