Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/kafka: Shrink buffers in sink_collection operator #30812

Merged

Conversation

ParkMyCar
Copy link
Member

In the Kafka sink_collection operator we re-use two Vecs to buffer messages, but never shrink them. So it's possible for a large update to blow up the size of these Vecs and then we're stuck holding the heap allocation for a while.

Motivation

Possibly fix an issue we've been seeing.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ParkMyCar ParkMyCar requested a review from petrosagg December 12, 2024 21:12
@ParkMyCar ParkMyCar requested a review from a team as a code owner December 12, 2024 21:12
Copy link
Contributor

@petrosagg petrosagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ParkMyCar ParkMyCar merged commit 2122c46 into MaterializeInc:main Dec 12, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants