Remove "sympy_name" in from_sympy() calls: #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generally, we can get sympy_name from the object. Previously, we sometimes we had two-parameter "from_sympy()" calls and three-parameter calls where sometiems a parameter might not be used. Overall, I think this will simplifies things. Some type annotations were added.
|
Good! LGTM |
|
Great. I am now starting to look at adding some simple event tracing that will help me understand better what's going on in the code. It is sad that every time I start to look into doing something new I am haunted by weirdnesses from the past. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally, we can get sympy_name from the object.
Previously, we sometimes we had two-parameter "from_sympy()" calls and three-parameter calls where sometiems a parameter might not be used.
Overall, I think this will simplifies things.
Some type annotations were added.