tweak some error messages to be more like WMA... #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in particular Get::noopen, {First,Last,Most}::normal
axkr
reviewed
Sep 26, 2024
| @@ -589,24 +590,24 @@ class First(Builtin): | |||
| >> First[a + b + c] | |||
| = a | |||
| >> First[x] | |||
| : Nonatomic expression expected. | |||
| : Nonatomic expression expected at position 1 in First[x]. | |||
| = First[x] | |||
| >> First[{}] | |||
| : {} has zero length and no first element. | |||
| = First[{}] | |||
| """ | |||
|
|
|||
There was a problem hiding this comment.
First and Lastshould have a default value as second arg and attribute A_HOLD_REST.
There was a problem hiding this comment.
@axkr, you are right:
In[1]:= First[a]
First::normal: Nonatomic expression expected at position 1 in First[a].
Out[1]= First[a]
In[2]:= First[a, b]
Out[2]= b
In[3]:= First[a, b, c]
First::argt: First called with 3 arguments; 1 or 2 arguments are expected.
Out[3]= First[a, b, c]
In[4]:= ?? First
Out[4]= First[expr] gives the first element in expr
> . First[expr, def] gives the first element if it exists, or def
> otherwise.
Attributes[First]={HoldRest, Protected}
There was a problem hiding this comment.
Thanks - this should be handled now.
Properties on First and Last should be A_HOLD_REST (axel) Check that arguments are 1 or 2 (mmatera)
rocky
force-pushed
the
tune-Elements-of-Lists-msgs
branch
from
3f264ed
to
a7bf87b
Compare
rocky
force-pushed
the
tune-Elements-of-Lists-msgs
branch
from
a7bf87b
to
73b99f0
Compare
-- this time, for sure https://www.youtube.com/watch?v=pc4IFIXcDcs
rocky
force-pushed
the
tune-Elements-of-Lists-msgs
branch
from
f7828bb
to
d8f3987
Compare
mmatera
reviewed
Sep 26, 2024
mathics/builtin/list/eol.py
Outdated
| and len == 2 | ||
| and isinstance(first_elem, Atom) | ||
| ): | ||
| return expr.elements[1].evaluate(evaluation) |
There was a problem hiding this comment.
Just a comment: to call the evaluate(evaluation) method at the end is not needed: it is going to be called in the next rewrite_apply_eval iteration
There was a problem hiding this comment.
Ok - thanks. Will remove the explicit call.
mmatera
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in particular Get::noopen, {First,Last,Most}::normal