Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak some error messages to be more like WMA... #1094

Merged
merged 5 commits into from
Sep 26, 2024
Merged

tweak some error messages to be more like WMA... #1094

merged 5 commits into from
Sep 26, 2024

Commits on Sep 25, 2024

  1. tweak some error messages to be more like WMA... 

    in particular Get::noopen, {First,Last,Most}::normal
    @rocky
    rocky committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    58ed3e8 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Address review observations... 

    Properties on First and Last should be A_HOLD_REST (axel)
Check that arguments are 1 or 2 (mmatera)
    @rocky
    rocky committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7667677 View commit details
    Browse the repository at this point in the history

  2. Handle default args on First and Last

    @rocky
    rocky committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    73b99f0 View commit details
    Browse the repository at this point in the history

  3. Handle 2 arg First, Last where 1 arg is an Atom 

    -- this time, for sure https://www.youtube.com/watch?v=pc4IFIXcDcs
    @rocky
    rocky committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d8f3987 View commit details
    Browse the repository at this point in the history

  4. Remove unneded call to evaluate()

    @rocky
    rocky committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c669876 View commit details
    Browse the repository at this point in the history