Fix a crash produced when a pattern contains a BoxExpression as an element. #626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash produced when a pattern contains a BoxExpression. Suppose for example that
we want to evaluate the expression
The pattern in the rule contains a RowBox, so in the evaluation,
F[RowBox[list___]]
is evaluated. Then, theRowBox[]
expression is replaced by aRowBox
object. Then, whenRule
is evaluated, Pattern.create is called, withExpression(Symbol("Global`F"), RowBox(...))
as a parameter. It is not an Expression, soPatter.create
fails raising an exception.In this PR this behavior is fixed by catching this case and converting
RowBox
into anExpression
before creating the pattern.BuiltinExpression.get_sort_key
method.