Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbol init cleanup 2 #691

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Symbol init cleanup 2 #691

wants to merge 12 commits into from

Commits on Jan 7, 2023

  1. WIP - separate PredefinedSymbol from Symbol .. 

    PredefinedSymbol acts more like a numeric constant.
    @rocky
    rocky committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    35f6d61 View commit details
    Browse the repository at this point in the history

  2. Clarify Symbol as per mmatera 

    Update builtin/atomic/symbols.py according to current standards.
    @rocky
    rocky committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    4d49f6b View commit details
    Browse the repository at this point in the history

  3. fix MakeBoxes[Infix[...]]

    @mmatera @rocky
    mmatera authored and rocky committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    21a81ad View commit details
    Browse the repository at this point in the history

  4. MakeBoxes[Infix[...],form]-> Infix

    @mmatera @rocky
    mmatera authored and rocky committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    e8ca60a View commit details
    Browse the repository at this point in the history

  5. alternative implementation

    @mmatera @rocky
    mmatera authored and rocky committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    a417f00 View commit details
    Browse the repository at this point in the history

  6. moving do_eval_infix to be a non-member function in the same module.

    @mmatera @rocky
    mmatera authored and rocky committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    889e9fc View commit details
    Browse the repository at this point in the history

  7. adding comment

    @mmatera @rocky
    mmatera authored and rocky committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    94f2bb0 View commit details
    Browse the repository at this point in the history

  8. Move towards segregating box from eval 

    * Some long lines split
* some linting
* correct a wrong symbol
    @rocky
    rocky committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    11a7eec View commit details
    Browse the repository at this point in the history

  9. Adjust builtins_precedence and doc parenthesize 

    We should be using Symbols insead of string where possible.
builtins_precedence is really used in eval/makeboxes so it is defined
there.

It is just initialized in `mathics.buitins`.
    @rocky
    rocky committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    0d4ce19 View commit details
    Browse the repository at this point in the history

  10. PredefinedSymbol -> SymbolConstant... 

    and try to clearify what is up here.
    @rocky
    rocky committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    a43fd5e View commit details
    Browse the repository at this point in the history

  11. tweak docstring, more type annotations

    @rocky
    rocky committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    45c12c4 View commit details
    Browse the repository at this point in the history

  12. Residual mege changes to get this working again

    @rocky
    rocky committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    c4c1e6d View commit details
    Browse the repository at this point in the history