Move more builtin module loading code out of mathics/builtin/__init__.py
#875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some imports moved as well. is_symbol_name comes from mathics_scanner, not the parser.
And modularity is further improved.
rocky
force-pushed
the
load-module-control
branch
from
c7553f9
to
fe10358
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next iteration in sequence of refactorings.
Here, the remaining code that should have been put into a function has been moved out of
mathics/builtin/__init__.pyand intomathics.core.builtin_loadand imports have been adjusted which reduces circular dependencies.Remaining refactoring:
Initiate the module loading from the
mathics.core.builtin_loadmodule.Loading currently needs to be rewritten. It currently gets all builtin module names. then from that returned collection imports all module names, then from that collection ... all ... all ...
Instead, of many "all" loops, we need to do follow through everything a specific module name. To do everything, that is in one loop (over builtin module names) and no further loops would follow.