What we need to get PDF doc to build... #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Some references corrected. * Remove duplicate sections (in both test and doc) in guide sections * Fix a small markup typo in ComplexExpand formatting
Both are pretty short and it makes the overall organization more coherent. (Should both code grow a lot, we can create a directory to make this a "Guide Section".
Also start regularizing section summary text here.
remove Builtin object field "abstract" which is not used.
mmatera
reviewed
Jul 11, 2023
mathics/builtin/datentime.py
Outdated
| @@ -987,7 +986,7 @@ class DateStringFormat(Predefined): | |||
|
|
|||
| <dl> | |||
| <dt>'$DateStringFormat' | |||
| <dd>gives the format used for dates generated by 'DateString'. | |||
| <dd>get the format used for dates generated by 'DateString'. | |||
There was a problem hiding this comment.
I had the feeling that in the docstring we used the style "[Expression] does/returns/gives ..." using a third person in the simple present tense, while the summary_text was in the imperative form, wasn't it?
There was a problem hiding this comment.
This should have just been on the summary text. I'll change this.
In the summary text it is 3rd person active. "get" or "give" would work but for summary text "get" seems to be what is used most.
(But in summary_text it is "get").
|
Should commit before I start adding more (of which I am sure there is a lot more to do). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last release, it was difficult enough to get things to build. Going over documentation suffered a little.
I am now starting to do this as part of releasing new docker images. (The last one was 4 months ago)