Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for sympy 1.12 #882

Merged
merged 1 commit into from
Jul 20, 2023
Merged

support for sympy 1.12 #882

merged 1 commit into from
Jul 20, 2023

Conversation

mmatera
Copy link
Contributor

@mmatera mmatera commented Jul 20, 2023

This PR allows to use sympy 1.12, without breaking the tests, fixing #881.

@rocky
Copy link
Member

rocky commented Jul 20, 2023

This is good. Make a new branch from tag 6.0.1 (I think the SHA1 is 62b8b7f) and open an additional PR applying this commit to that branch. Thanks.

@mmatera
Copy link
Contributor Author

mmatera commented Jul 20, 2023

For some reason, when I try to make a PR over these branches, github just shows me the differences, but no a PR button.

@rocky
Copy link
Member

rocky commented Jul 20, 2023

The branch current

For some reason, when I try to make a PR over these branches, github just shows me the differences, but no a PR button.

That is because the branch currently has the first commit as part of it.

@rocky rocky marked this pull request as ready for review July 20, 2023 04:00
@rocky
Copy link
Member

rocky commented Jul 20, 2023

LGTM

@rocky rocky merged commit 3ed2420 into master Jul 20, 2023
11 checks passed
@rocky rocky deleted the issue881 branch July 20, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants